ci(e2e): install with pnpm 11, matching the version developers run - #836
Merged
Conversation
📝 WalkthroughWalkthroughThe e2e gitignore now excludes ChangesE2E install hygiene
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/e2e/.gitignore`:
- Around line 6-10: Update the comment in tests/e2e/.gitignore to say pnpm “may
write” the file instead of stating that it always “writes” it, while preserving
the remaining explanation unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6b03b910-d3f1-4161-b282-84921b8660be
📒 Files selected for processing (1)
tests/e2e/.gitignore
CI pinned pnpm 9 while local installs are on 11, and the gap was not
cosmetic: pnpm 10 stopped running a dependency's install scripts unless the
package is named in `pnpm-workspace.yaml`, so a local `pnpm install` failed
with ERR_PNPM_IGNORED_BUILDS and dropped a placeholder workspace file that,
if committed, broke CI's pnpm 9 install ("packages field missing or empty").
The two halves have to land together — pnpm 9 rejects the workspace file
and pnpm 11 requires it — so this bumps the workflow and adds the file in
one commit. esbuild (via vitest) keeps its install script enabled, which is
what pnpm 9 did by default, so the harness behaves as before.
Verified by running the full e2e suite under pnpm 11.17.0: 163 files, 422
passed, 3 skipped.
jarvis9443
force-pushed
the
chore/ignore-pnpm-workspace
branch
from
July 29, 2026 01:09
ba235c7 to
7dbffb9
Compare
jarvis9443
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI pinned pnpm 9 while local installs are on 11. The gap is not cosmetic — pnpm 10 changed install-script handling, and the two versions now disagree about a file:
pnpm-workspace.yaml. A localpnpm installintests/e2efails withERR_PNPM_IGNORED_BUILDS: esbuild@0.28.1and writes a placeholder workspace file.pnpm-workspace.yamlas a workspace manifest and exits withERROR packages field missing or emptybefore running a test. That is what happened on feat(headers): request-context variables in default_headers + client-header forwarding allowlist #835.So the harness is currently unbuildable locally without producing a file that breaks CI. Pinning CI to the version developers actually run closes it.
The workflow bump and the workspace file have to land in the same commit — pnpm 9 rejects the file, pnpm 11 requires it. esbuild keeps its install script enabled, which is what pnpm 9 did by default, so nothing about the harness's behavior changes.
version: 11follows the existing major-line style ofversion: 9, so patch releases still flow.Verification: full e2e suite under pnpm 11.17.0 — 163 files, 422 passed, 3 skipped, 0 failed.
Supersedes the narrower "ignore the stray file" approach this PR originally carried: with CI on pnpm 11 the file is real configuration, not an artifact.