Fix document manager constructor not updating cached values #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepfuriya
force-pushed
the
document-manager-fix
branch
3 times, most recently
from
3655caf to
a63b0ba
Compare
satyakigh
reviewed
Nov 21, 2025
Zee2413
force-pushed
the
document-manager-fix
branch
from
a63b0ba to
56095b7
Compare
Collaborator
|
Hold off on merging this until release bugs are fixed |
deepfuriya
force-pushed
the
document-manager-fix
branch
2 times, most recently
from
03e47b0 to
9f49305
Compare
satyakigh
force-pushed
the
document-manager-fix
branch
from
9f49305 to
b5069bb
Compare
deepfuriya
force-pushed
the
document-manager-fix
branch
3 times, most recently
from
ea1654e to
edf7021
Compare
Zee2413
reviewed
Nov 26, 2025
Zee2413
reviewed
Nov 26, 2025
deepfuriya
force-pushed
the
document-manager-fix
branch
from
edf7021 to
12faa49
Compare
Zee2413
previously approved these changes
Dec 1, 2025
deepfuriya
force-pushed
the
document-manager-fix
branch
from
12faa49 to
29a517a
Compare
deepfuriya
force-pushed
the
document-manager-fix
branch
2 times, most recently
from
be0c017 to
b819f6a
Compare
Zee2413
previously approved these changes
Dec 1, 2025
satyakigh
reviewed
Dec 2, 2025
deepfuriya
force-pushed
the
document-manager-fix
branch
from
b819f6a to
ee4b2e6
Compare
deepfuriya
force-pushed
the
document-manager-fix
branch
2 times, most recently
from
c4d5444 to
fd3e4a2
Compare
Zee2413
force-pushed
the
document-manager-fix
branch
from
fd3e4a2 to
31e34a6
Compare
satyakigh
reviewed
Dec 4, 2025
deepfuriya
force-pushed
the
document-manager-fix
branch
from
31e34a6 to
5e45c96
Compare
deepfuriya
force-pushed
the
document-manager-fix
branch
2 times, most recently
from
6c85d51 to
7620b6f
Compare
satyakigh
force-pushed
the
document-manager-fix
branch
from
7620b6f to
47ac74c
Compare
deepfuriya
force-pushed
the
document-manager-fix
branch
3 times, most recently
from
5a6cbd1 to
bb9f841
Compare
added 6 commits
December 9, 2025 16:30
deepfuriya
force-pushed
the
document-manager-fix
branch
from
bb9f841 to
08dc41f
Compare
satyakigh
reviewed
Dec 10, 2025
| s3Service, | ||
| document.documentType, | ||
| document.uri, | ||
| document.contents() ?? '', |
Collaborator
There was a problem hiding this comment.
This should probably throw at line 100
| } | ||
|
|
||
| const content = document.contents(); | ||
| if (!content) { |
Collaborator
There was a problem hiding this comment.
This sill be true if contents is both undefined or empty which breaks line 33
| document.documentType, | ||
| document.uri, | ||
| document.contents(), | ||
| document.contents() ?? '', |
Collaborator
There was a problem hiding this comment.
This should be checked at like 92
| // Replace entire file with properly formatted JSON | ||
| snippetText = docFormattedText; | ||
| const endPosition = { line: document.lineCount, character: 0 }; | ||
| const endPosition = { line: document.lineCount ?? 0, character: 0 }; |
Collaborator
There was a problem hiding this comment.
Can we exit early if theres no document?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
DocumentsinsideDocumentManagerwhich cache the document object during creation and points to theTextDocumentreferencelanguageId,versionand 'lineCount' were only initialized in the constructor and never updated which caused a stale value issueDescription of changes:
Documentconstructor to pass in theTextDocumentas a function and get all the above mentioned values throughgetreference instead of initializing it in constructor.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.