Refactor release workflow to use gh CLI #444
Conversation
Replaces actions/upload-release-asset with gh CLI commands for uploading release assets. Simplifies release creation and asset upload steps, removes unused get-version action, and updates asset naming and upload logic for macOS and Linux builds.
There was a problem hiding this comment.
Pull request overview
This PR modernizes the release workflow by replacing the deprecated actions/create-release and actions/upload-release-asset actions with the GitHub CLI (gh). It simplifies the workflow by eliminating the need for upload URLs and directly using gh commands for release creation and asset uploads.
Key changes:
- Replaces GitHub Actions with
gh releaseCLI commands for creating releases and uploading assets - Removes the
upload_urloutput andget-version-actiondependency - Adds a checkout step to the
create_releasejob to enableghCLI usage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: actions/[email protected] | ||
| run: | | ||
| TAG="${{ needs.create_release.outputs.tag_name }}" | ||
| cp release/xcbeautify.zip "xcbeautify-${TAG}-universal-apple-macosx.zip" |
There was a problem hiding this comment.
The macOS job uses cp to copy files before uploading (lines 46, 53, 60), while the Linux job uses mv to rename the file (line 83). This is inconsistent. Consider using mv for all jobs to avoid leaving duplicate files in the workspace after the upload completes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 17 17
Lines 2125 2125
=======================================
Hits 1949 1949
Misses 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot Review the latest changes |
|
@cpisciotta I've opened a new pull request, #445, to work on those changes. Once the pull request is ready, I'll request review from you. |
Replaces actions/upload-release-asset with gh CLI commands for uploading release assets. Simplifies release creation and asset upload steps, removes unused get-version action, and updates asset naming and upload logic for macOS and Linux builds.