Skip to content

adding goldens for BLS imports#2090

Open
balit-raibot wants to merge 6 commits into
datacommonsorg:masterfrom
balit-raibot:adding_goldens_bls_imports
Open

adding goldens for BLS imports#2090
balit-raibot wants to merge 6 commits into
datacommonsorg:masterfrom
balit-raibot:adding_goldens_bls_imports

Conversation

@balit-raibot

@balit-raibot balit-raibot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR adds golden data for BLS imports:
BLS_CPI: cpi_u and c_cpi_u sub-imports of BLS_CPI. cpi_w doesn't have any golden data.
BLS_CES_State

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds golden summary reports for the c_cpi_u and cpi_u datasets. The reviewer pointed out that the golden summary report for cpi_w is missing and should be added to ensure complete test coverage for all datasets defined in the manifest.

Comment thread scripts/us_bls/cpi/golden_data/golden_summary_report_cpi_u.csv
@niveditasing niveditasing self-requested a review July 10, 2026 06:07
@balit-raibot balit-raibot changed the title adding goldens for BLS_CPI adding goldens for BLS imports Jul 10, 2026
@balit-raibot

Copy link
Copy Markdown
Contributor Author

@gemini-code-assist review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces validation configurations and golden summary reports for the US BLS CPI and CES State data imports, updating their manifests to reference the new validation files. The reviewer identified that the relative paths to the golden summary reports in both validation_config.json files are incorrect, pointing to non-existent directories by going up four levels instead of three. Correcting these paths is necessary to ensure the validation runner can locate the golden files.

Comment thread scripts/us_bls/cpi/validation_config.json
Comment thread scripts/us_bls/cpi/validation_config.json
Comment thread statvar_imports/us_bls/bls_ces_state/validation_config.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants