-
Notifications
You must be signed in to change notification settings - Fork 149
adding goldens for BLS imports #2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
balit-raibot
wants to merge
6
commits into
datacommonsorg:master
Choose a base branch
from
balit-raibot:adding_goldens_bls_imports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
38ef9d3
adding goldens for BLS_CPI
balit-raibot 1c093df
added validation config
balit-raibot 0601538
added validation config
balit-raibot 87ef7ee
adding goldens for BLS_CES_State
balit-raibot ddfc025
adding goldens for BLS_CES_State
balit-raibot 398ff2a
Merge branch 'master' into adding_goldens_bls_imports
balit-raibot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
scripts/us_bls/cpi/golden_data/golden_summary_report_c_cpi_u.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| "NumPlaces","ScalingFactors","Units","MeasurementMethods","StatVar","MinDate","observationPeriods" | ||
| "1","[]","[IndexPointBasePeriodDecember1999Equals100]","[BLSChained]","dc/x6l3mg60hpe7c","1999-12","[]" |
2 changes: 2 additions & 0 deletions
2
scripts/us_bls/cpi/golden_data/golden_summary_report_cpi_u.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| "MinDate","NumPlaces","Units","ScalingFactors","MeasurementMethods","StatVar","observationPeriods" | ||
| "1947-01","1","[IndexPointBasePeriod1982To1984Equals100]","[]","[BLSUnchained]","dc/x6l3mg60hpe7c","[]" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "schema_version": "1.0", | ||
| "rules": [ | ||
| { | ||
| "rule_id": "check_deleted_records_percent", | ||
| "description": "Checks that the percentage of deleted records for the entire import is within threshold.", | ||
| "validator": "DELETED_RECORDS_PERCENT", | ||
| "params": { "threshold": 0.1} | ||
| }, | ||
| { | ||
| "rule_id": "check_goldens_cpi_u", | ||
| "description": "Validates cpi_u data against its golden summary report.", | ||
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": "../../../../golden_data/golden_summary_report_cpi_u.csv", | ||
|
niveditasing marked this conversation as resolved.
|
||
| "input_files": "../../input0/genmcf/summary_report.csv" | ||
| } | ||
| }, | ||
| { | ||
| "rule_id": "check_goldens_c_cpi_u", | ||
| "description": "Validates c_cpi_u data against its golden summary report.", | ||
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": "../../../../golden_data/golden_summary_report_c_cpi_u.csv", | ||
|
niveditasing marked this conversation as resolved.
|
||
| "input_files": "../../input2/genmcf/summary_report.csv" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
2 changes: 2 additions & 0 deletions
2
statvar_imports/us_bls/bls_ces_state/golden_data/golden_summary_report.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| "MinDate","MeasurementMethods","NumPlaces","observationPeriods","ScalingFactors","StatVar","Units" | ||
| "2020-01","[BLSSeasonallyUnadjusted, BLSSeasonallyAdjusted]","104","[P1M]","[]","Count_Person_Employed_TotalNonfarm","[]" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
statvar_imports/us_bls/bls_ces_state/validation_config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "schema_version": "1.0", | ||
| "rules": [ | ||
| { | ||
| "rule_id": "check_deleted_records_percent", | ||
| "description": "Checks that the percentage of deleted records for the entire import is within threshold.", | ||
| "validator": "DELETED_RECORDS_PERCENT", | ||
| "params": { "threshold": 0.1} | ||
| }, | ||
| { | ||
| "rule_id": "check_goldens_summary_report", | ||
| "validator": "GOLDENS_CHECK", | ||
| "params": { | ||
| "golden_files": "../../../../golden_data/golden_summary_report.csv" | ||
|
niveditasing marked this conversation as resolved.
|
||
| } | ||
| } | ||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.