Fixed: Memory view not supporting 64-bit address while using GnuMcuLaunch #647
Conversation
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
On code inspection this looks right to me.
|
Is the GdbMemoryBlockRetrieval class available in the older Eclipse that these plugins are based on? |
Based on my understanding, GdbMemoryBlockRetrieval is not available in the older Eclipse/CDT versions that the Embedded CDT plug-ins were based on. |
|
There is a plan to align the plug-ins with a more recent Eclipse version, but I'm not sure how long it'll take. Please leave this PR open, we'll consider it when ready. |
Ok, Thanks |
jonahgraham
force-pushed
the
fix-64bit-memory-view
branch
from
9679976 to
c64904a
Compare
|
I have rebased this on latest develop HEAD. This can be merged if CI reports success. |
GdbMemoryBlockRetrieval has been around long enough that the code builds ok. So I think this is good to go. I will merge this, and I look forward to @pnipin testing out the built version when it is available to ensure that it has integrated properly. |
|
@pnipin Can you test out https://download.eclipse.org/embed-cdt/builds/develop/p2/ which now has this change and report back if it works correctly in your use case? |
3 participants
Fix for: #645
CDT have added support for 64-bit memory addresses long before. Code changes for the support are in the class GdbMemoryBlockRetrieval which inherits from DsfMemoryBlockRetrieval. Embedded CDT launches are using GnuMcuLaunch class (Embedded CDT launcher, used to initialize the memory block retrieval used by the Peripherals view). This launcher uses PeripheralMemoryBlockRetrieval which directly inherits from DsfMemoryBlockRetrieval and misses the 64-bit support in GdbMemoryBlockRetrieval class. If parent class of PeripheralMemoryBlockRetrieval is changed to GdbMemoryBlockRetrieval memory view correctly displays the address contents.