Skip to content

Conversation

@miqs1992
Copy link
Contributor

Issue

Closes: #8136

Description

Based on the request in the issue, I added

  • TC.yaml to config/zones
    • Basic geography data
    • Capacity based on Ember API (only data up to 2023)
    • Mixin based on US Dep of Energy doc (I wanted to show some amount of solar energy which is not visible in Ember data)
    • Connection to Ember parser
  • Added shape to world.geojson and zone names to en and pl locales
  • Added mapping to EMBER.py

Preview

Screenshot 2025-07-24 at 10 27 30

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added Frontend 🎨 python Pull requests that update Python code zone config Pull request or issue for zone configurations capacity parser labels Jul 24, 2025
@VIKTORVAV99 VIKTORVAV99 self-requested a review July 25, 2025 09:31
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

We are making some changes into what information is available in the zones config so I'll hold off on merging this for a little while longer but everything looks good.

I have one small suggestion around the capacity though.

Comment on lines +14 to +16
- datetime: '2023-01-01'
source: Ember, Yearly electricity data
value: 90.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this value is the same as the previous one it can be removed.

@VIKTORVAV99 VIKTORVAV99 self-requested a review August 8, 2025 08:55
@VIKTORVAV99
Copy link
Member

@miqs1992 could you also add the translations to web/public/locales/en.json, this is a legacy file still used by the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

capacity parser Frontend 🎨 python Pull requests that update Python code zone config Pull request or issue for zone configurations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a zone for Turks and Caicos

2 participants