Skip to content

[eas-cli] Wire refresh ad-hoc profile through build:internal and prepareJob#3769

Open
sswrk wants to merge 1 commit into
szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflowfrom
szymonswierk/eng-21094-cli-build-internal-refresh
Open

[eas-cli] Wire refresh ad-hoc profile through build:internal and prepareJob#3769
sswrk wants to merge 1 commit into
szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflowfrom
szymonswierk/eng-21094-cli-build-internal-refresh

Conversation

@sswrk
Copy link
Copy Markdown
Contributor

@sswrk sswrk commented May 21, 2026

Why

Workflow builds run eas build:internal on EAS workers to resolve credentials and emit the job JSON. The base branch adds --refresh-ad-hoc-provisioning-profile to eas build, but that flag was not available on build:internal, and the iOS job did not persist refresh_ad_hoc_provisioning_profile when the flag was set.

Without this wiring, git-based/workflow builds could not trigger ad-hoc profile refresh or pass the intent through to the job payload.

How

  • Add --refresh-ad-hoc-provisioning-profile to eas build:internal and pass it into runBuildAndSubmitAsync (same behavior as eas build).
  • In prepareJob.ts, set refresh_ad_hoc_provisioning_profile: true on the iOS job when the credentials context has the flag enabled.

Test Plan

yarn typecheck

@linear
Copy link
Copy Markdown

linear Bot commented May 21, 2026

ENG-21094

Copy link
Copy Markdown
Contributor Author

sswrk commented May 21, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sswrk sswrk changed the title [eas-cli] Wire refresh ad-hoc profile through build:internal and prepareJob [eas-cli] Wire refresh ad-hoc profile through build:internal and prepareJob May 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.88%. Comparing base (21d23de) to head (20da401).

Files with missing lines Patch % Lines
packages/eas-cli/src/build/ios/prepareJob.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                                  Coverage Diff                                                   @@
##           szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow    #3769      +/-   ##
======================================================================================================================
- Coverage                                                                               56.88%   56.88%   -0.00%     
======================================================================================================================
  Files                                                                                     904      904              
  Lines                                                                                   39177    39178       +1     
  Branches                                                                                 8202     8203       +1     
======================================================================================================================
  Hits                                                                                    22283    22283              
- Misses                                                                                  15422    15423       +1     
  Partials                                                                                 1472     1472              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk sswrk force-pushed the szymonswierk/eng-21094-cli-build-internal-refresh branch from 10da52d to 20da401 Compare May 21, 2026 12:41
@sswrk sswrk added the no changelog PR that doesn't require a changelog entry label May 21, 2026
@github-actions
Copy link
Copy Markdown

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@sswrk sswrk marked this pull request as ready for review May 21, 2026 12:58
@sswrk sswrk requested a review from sjchmiela May 21, 2026 12:58
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/commands/build/** @sjchmiela
packages/eas-cli/src/build/** @sjchmiela

Generated by CodeMention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant