Skip to content

[build-tools] Pass refresh ad-hoc provisioning profile through build:internal#3770

Open
sswrk wants to merge 1 commit into
szymonswierk/eng-21094-cli-build-internal-refreshfrom
szymonswierk/eng-21094-build-tools-refresh
Open

[build-tools] Pass refresh ad-hoc provisioning profile through build:internal#3770
sswrk wants to merge 1 commit into
szymonswierk/eng-21094-cli-build-internal-refreshfrom
szymonswierk/eng-21094-build-tools-refresh

Conversation

@sswrk
Copy link
Copy Markdown
Contributor

@sswrk sswrk commented May 21, 2026

Why

Git-based integration builds call eas build:internal via runEasBuildInternalAsync. The refresh flag must reach the CLI and remain on the job object returned to the rest of the build.

How

Forward --refresh-ad-hoc-provisioning-profile when set on the iOS job; retain refresh_ad_hoc_provisioning_profile in validateEasBuildInternalResult.

Test Plan

cd packages/build-tools && yarn test src/common/__tests__/easBuildInternal.test.ts

@linear
Copy link
Copy Markdown

linear Bot commented May 21, 2026

ENG-21094

Copy link
Copy Markdown
Contributor Author

sswrk commented May 21, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.93%. Comparing base (20da401) to head (67b630b).

Files with missing lines Patch % Lines
...ackages/build-tools/src/common/easBuildInternal.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           szymonswierk/eng-21094-cli-build-internal-refresh    #3770      +/-   ##
=====================================================================================
+ Coverage                                              56.88%   56.93%   +0.05%     
=====================================================================================
  Files                                                    904      904              
  Lines                                                  39178    39187       +9     
  Branches                                                8203     8210       +7     
=====================================================================================
+ Hits                                                   22283    22306      +23     
+ Misses                                                 15423    15411      -12     
+ Partials                                                1472     1470       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk sswrk force-pushed the szymonswierk/eng-21094-cli-build-internal-refresh branch from 10da52d to 20da401 Compare May 21, 2026 12:41
@sswrk sswrk force-pushed the szymonswierk/eng-21094-build-tools-refresh branch from dc694d0 to d91ca7e Compare May 21, 2026 12:41
@sswrk sswrk force-pushed the szymonswierk/eng-21094-build-tools-refresh branch from d91ca7e to 67b630b Compare May 21, 2026 12:43
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@sswrk sswrk marked this pull request as ready for review May 21, 2026 13:06
@sswrk sswrk requested a review from sjchmiela May 21, 2026 13:06
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant