Skip to content

Add azure-well-architected-review skill - #2448

Merged
aaronpowell merged 2 commits into
github:mainfrom
AClerbois:feature/azure-well-architected-review
Jul 28, 2026
Merged

Add azure-well-architected-review skill#2448
aaronpowell merged 2 commits into
github:mainfrom
AClerbois:feature/azure-well-architected-review

Conversation

@AClerbois

@AClerbois AClerbois commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

Adds an azure-well-architected-review skill that performs a structured Azure Well-Architected Framework (WAF) review of a workload's IaC and deployed infrastructure, then creates GitHub issues to track remediation.

The repository already ships an aws-well-architected-review skill, but no Azure equivalent existed. Existing Azure artifacts (e.g. azure-principal-architect agent) provide conversational design guidance rather than an actionable audit workflow. This skill fills that gap by mirroring the proven AWS skill structure, adapted to Azure:

  • Reviews all 5 Azure WAF pillars (Reliability, Security, Cost Optimization, Operational Excellence, Performance Efficiency) with concrete, Azure-specific checklists (managed identities, private endpoints, availability zones, Defender for Cloud, Azure Policy, budgets, etc.)
  • Discovers IaC in Bicep, Terraform (azurerm/azapi), and ARM templates, with an az resource list fallback when no IaC is present
  • Classifies findings by risk level, confirms with the user, then creates individual GitHub issues plus an EPIC tracking issue
  • Remediation examples in Bicep with Azure CLI fallbacks, referencing Microsoft Learn / microsoft.docs.mcp for up-to-date guidance

npm run skill:validate passes and docs/README.skills.md was regenerated via the build.


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes

The skill intentionally mirrors the structure of skills/aws-well-architected-review/SKILL.md for consistency between the two cloud review workflows.


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

Adds a skill that performs a structured Azure Well-Architected Framework
review of a workload's IaC (Bicep, Terraform, ARM) and deployed
infrastructure across the 5 WAF pillars, then creates GitHub issues to
track remediation. Mirrors the existing aws-well-architected-review
skill, which had no Azure equivalent.
@AClerbois
AClerbois requested a review from aaronpowell as a code owner July 27, 2026 09:24
Copilot AI review requested due to automatic review settings July 27, 2026 09:24
@github-actions github-actions Bot added new-submission PR adds at least one new contribution skills PR touches skills labels Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 2 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 1
ℹ️ Info 0
Severity Rule File Line Match
🟠 package-exec-command docs/README.skills.md 31 | [acreadiness-assess](../skills/acreadiness-assess/SKILL.md)<br />`gh skills install github/awesome-copilot acreadiness-assess` | Run the AgentRC readiness assessment on the curre

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

✅ All checks passed

Scope Checked
Skills 1
Agents 0
Total 1
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ npm warn EBADENGINE Unsupported engine {
ℹ️ npm warn EBADENGINE package: 'commander@15.0.0',
ℹ️ npm warn EBADENGINE required: { node: '>=22.12.0' },
ℹ️ npm warn EBADENGINE current: { node: 'v20.20.2', npm: '10.8.2' }
ℹ️ npm warn EBADENGINE }
ℹ️ npm warn deprecated prebuild-install@7.1.3: No longer maintained. Please contact the author of the relevant native addon; alternatives are available.
ℹ️ ✅ azure-well-architected-review (2/2 checks passed)
ℹ️ ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️ ✓ spec-compliance: All spec checks passed.
ℹ️ ✓ [valid-refs] All file references across 1 skill(s) are valid.
Full linter output
### Linting skills/azure-well-architected-review
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: 'commander@15.0.0',
npm warn EBADENGINE   required: { node: '>=22.12.0' },
npm warn EBADENGINE   current: { node: 'v20.20.2', npm: '10.8.2' }
npm warn EBADENGINE }
npm warn deprecated prebuild-install@7.1.3: No longer maintained. Please contact the author of the relevant native addon; alternatives are available.
✅ azure-well-architected-review (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Azure Well-Architected Framework review skill and publishes it in the skills catalog.

Changes:

  • Adds five-pillar Azure architecture review guidance.
  • Defines risk classification and GitHub issue templates.
  • Updates the generated skills index.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
skills/azure-well-architected-review/SKILL.md Defines the Azure review workflow.
docs/README.skills.md Lists the new skill.

Comment thread skills/azure-well-architected-review/SKILL.md
Comment thread skills/azure-well-architected-review/SKILL.md
Comment thread skills/azure-well-architected-review/SKILL.md Outdated
- Step 2: always inventory live Azure resources and compare with IaC to
  surface drift, instead of scanning IaC only
- Step 5: add an explicit confirmation gate before any GitHub issue
  creation; ambiguous or negative responses stop with a console report
- Fix nested code fences in the issue-body template by using a
  four-backtick wrapper
Copilot AI review requested due to automatic review settings July 27, 2026 09:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

skills/azure-well-architected-review/SKILL.md:12

  • IaC is listed as mandatory, but Step 2 and the PR's advertised az resource list fallback explicitly support workloads with no IaC. An agent following this prerequisite can stop before reaching that live-only review path. Mark IaC as optional so the fallback remains usable.
- IaC files present in the repository (Bicep, Terraform, or ARM templates)

@aaronpowell aaronpowell self-assigned this Jul 28, 2026
@aaronpowell
aaronpowell merged commit 5c1ce5f into github:main Jul 28, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-submission PR adds at least one new contribution skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants