Closed
refactor: introduce shared/smoke-engine-base.md to consolidate smoke test scaffold#47530
Conversation
…lows Closes #47459 - Create `.github/workflows/shared/smoke-engine-base.md` that bundles `shared/gh.md` + `shared/token-telemetry-check.md` + `shared/reporting-otlp.md` - Update all 8 engine smoke workflows to use `smoke-engine-base.md`: - smoke-claude.md - smoke-codex.md - smoke-copilot-aoai-apikey.md - smoke-copilot-aoai-entra.md - smoke-copilot-arm.md - smoke-copilot.md - smoke-gemini.md - smoke-opencode.md - Recompile all workflows (261/261 success, 0 errors) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Create shared/smoke-engine-base.md for standardizing smoke test workflows
refactor: introduce shared/smoke-engine-base.md to consolidate smoke test scaffold
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8 engine smoke workflows (
claude,codex,copilot,copilot-arm,copilot-aoai-*,gemini,opencode) each independently imported the samegh.md+token-telemetry-check.md+reporting-otlp.mdtriplet, creating divergence risk and boilerplate.Changes
New
shared/smoke-engine-base.md— aggregator that imports the three shared components:8 smoke workflows updated — the 3-import combination (or its
reporting.md+otlp.mdequivalent) replaced withshared/smoke-engine-base.md; engine-specific extras (github-guard-policy.md,mcp/serena-go.md,go-make.md, etc.) remain as additional importssmoke-gemini.md,smoke-opencode.mdsmoke-copilot-arm.md,smoke-codex.mdsmoke-claude.mdsmoke-copilot-aoai-{apikey,entra}.md,smoke-copilot.md