Export callback globals on Windows#3087
Open
Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Export callback globals on Windows#3087Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
On Windows, global variables like mju_user_* and mjcb_* must be explicitly exported with __declspec(dllexport) in their definitions to be included in the import library (.lib). This change adds the MJAPI macro to these definitions, fixing linkage errors in non-MSVC environments (like Rust or MinGW). Fixes google-deepmind#3060
Collaborator
|
This looks like the correct fix, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes linkage issues on Windows where global callback variables were not being correctly exported in the MuJoCo DLL.
Changes
This ensures these symbols are included in the .lib import library, allowing them to be used by researchers using Rust or other non-MSVC toolchains on Windows.
Fixes #3060