Fix ResolveReferences for Empty Sidesites#3125
Closed
tomstewart89 wants to merge 1 commit intogoogle-deepmind:mainfrom
Closed
Fix ResolveReferences for Empty Sidesites#3125tomstewart89 wants to merge 1 commit intogoogle-deepmind:mainfrom
tomstewart89 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
This fix is now implemented with 6ec808e so I'll go ahead and close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This PR should fix the issue I raised over here: #3119
The Problem
spatialtendon with a wrappinggeomthat doesn't specify asidesitemjs_attachand specify a prefix and/or suffixmjCTendon::ResolveReferenceswhere the sidesite is namedprefix + "" + suffixmjCWrap::ResolveReferencestries to find the siteprefix + "" + suffix, fails and throws.mjCModel::CopyListand the tendon is skipped due to this continue statementThe Fix
Don't apply the prefix and suffix when a spatial tendon's
sidesiteis empty. That'll letmjCTendon::ResolveReferencesknow that it need not search for thesite.To add some test coverage for this, I also added a
spatialtendon to thexml_childused byMujocoTest.AttachSame,MujocoTest.AttachDifferentandMujocoTest.AttachFrameinuser_api_test.cc. These tests should all fail without the change added touser_objects.cc