fix(migration): allow getattr in restricted unpickler - #6734
Open
mikemikimike wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6636
Link to Issue or Description of Change
This fixes the Python 3.11 migration failure where Pydantic-generated
EventActionspickles can referencebuiltins.getattr. The restricted unpickler rejected that standard reduction, logged a warning, and silently migrated the actions as empty, losingrequested_auth_configs,requested_tool_confirmations, andcompaction.The restricted loader now permits only the specific
builtins.getattrglobal in addition to the existing allowlist. This preserves the security boundary while allowing the legitimate pickle shape produced in supported environments. No public API or unsafe-unpickling behavior changes.Testing Plan
Unit Tests:
git diff --check: passed.uv run pytest tests/unittests/sessions/migration/test_migration.py -qfastapiis not installed. The existing regression testtest_migrate_from_sqlalchemy_pickle_preserves_nested_safe_actions_picklecovers the reported failure path.Manual End-to-End (E2E) Tests:
Not run; this is an offline migration/unpickling change covered by the unit test.
Checklist