docs(hermetic-build): improve usability of development guide#12362
docs(hermetic-build): improve usability of development guide#12362diegomarquezp wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the DEVELOPMENT.md guide for hermetic builds by adding a step to clone the googleapis repository and adjusting the Docker execution command parameters. Feedback was provided to revert a change to the Maven project list path, as the updated path would likely cause the command to fail when executed from the repository root.
| org.apache.maven.plugins:maven-help-plugin:evaluate \ | ||
| -Dexpression=project.version \ | ||
| -pl gapic-generator-java \ | ||
| -pl sdk-platform-java/gapic-generator-java \ |
There was a problem hiding this comment.
The project list path has been changed to -pl sdk-platform-java/gapic-generator-java, which assumes the command is executed from the parent directory of the repository. Since this documentation is located within the sdk-platform-java repository, developers are more likely to be working from the repository root. If executed from the root, this command will fail. Consider using the relative path from the root or explicitly stating the required working directory.
| -pl sdk-platform-java/gapic-generator-java \ | |
| -pl gapic-generator-java \ |
There was a problem hiding this comment.
This makes sense, do we run the scripts from google-cloud-java or google-cloud-java/sdk-platform-java
2 participants
No description provided.