Skip to content

chore: remove autogen-snippets options with no value#16794

Merged
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:normalize-autogen-snippets
Apr 24, 2026
Merged

chore: remove autogen-snippets options with no value#16794
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:normalize-autogen-snippets

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 24, 2026

These are equivalent to autogen-snippets=True, which is already the default.

Fixes googleapis/librarian#5525

These are equivalent to autogen-snippets=True, which is already the
default.

Fixes googleapis/librarian#5525
@jskeet jskeet requested a review from parthea April 24, 2026 09:57
@jskeet jskeet requested a review from a team as a code owner April 24, 2026 09:57
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the autogen-snippets option from the Python API configurations for Document AI and Private Catalog in librarian.yaml. Feedback was provided to sort the remaining options alphabetically to enhance maintainability and consistency.

Comment thread librarian.yaml
Comment on lines 1899 to 1906
google/cloud/documentai/v1:
- autogen-snippets
- python-gapic-namespace=google.cloud
- python-gapic-name=documentai
- warehouse-package-name=google-cloud-documentai
google/cloud/documentai/v1beta3:
- autogen-snippets
- python-gapic-namespace=google.cloud
- python-gapic-name=documentai
- warehouse-package-name=google-cloud-documentai
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and better maintainability, please sort the opt_args_by_api lists for v1 and v1beta3 alphabetically. This makes it easier to find specific options and aligns with the repository's preference for sorted collections.

        google/cloud/documentai/v1:
          - python-gapic-name=documentai
          - python-gapic-namespace=google.cloud
          - warehouse-package-name=google-cloud-documentai
        google/cloud/documentai/v1beta3:
          - python-gapic-name=documentai
          - python-gapic-namespace=google.cloud
          - warehouse-package-name=google-cloud-documentai
References
  1. A general rule in this repository is to keep collections sorted to improve maintainability and consistency. While the rule specifically mentions dictionary keys, the same principle applies to this list of options.

Comment thread librarian.yaml
Comment on lines 3055 to 3057
- warehouse-package-name=google-cloud-private-catalog
- autogen-snippets
- python-gapic-namespace=google.cloud
- python-gapic-name=privatecatalog
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and better maintainability, please sort the opt_args_by_api list alphabetically. This makes it easier to find specific options and aligns with the repository's preference for sorted collections.

          - python-gapic-name=privatecatalog
          - python-gapic-namespace=google.cloud
          - warehouse-package-name=google-cloud-private-catalog
References
  1. A general rule in this repository is to keep collections sorted to improve maintainability and consistency. While the rule specifically mentions dictionary keys, the same principle applies to this list of options.

@jskeet jskeet merged commit 094ab6f into googleapis:main Apr 24, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python: make autogen-snippets options consistent

2 participants