chore: remove autogen-snippets options with no value#16794
chore: remove autogen-snippets options with no value#16794jskeet merged 1 commit intogoogleapis:mainfrom
Conversation
These are equivalent to autogen-snippets=True, which is already the default. Fixes googleapis/librarian#5525
There was a problem hiding this comment.
Code Review
This pull request removes the autogen-snippets option from the Python API configurations for Document AI and Private Catalog in librarian.yaml. Feedback was provided to sort the remaining options alphabetically to enhance maintainability and consistency.
| google/cloud/documentai/v1: | ||
| - autogen-snippets | ||
| - python-gapic-namespace=google.cloud | ||
| - python-gapic-name=documentai | ||
| - warehouse-package-name=google-cloud-documentai | ||
| google/cloud/documentai/v1beta3: | ||
| - autogen-snippets | ||
| - python-gapic-namespace=google.cloud | ||
| - python-gapic-name=documentai | ||
| - warehouse-package-name=google-cloud-documentai |
There was a problem hiding this comment.
For consistency and better maintainability, please sort the opt_args_by_api lists for v1 and v1beta3 alphabetically. This makes it easier to find specific options and aligns with the repository's preference for sorted collections.
google/cloud/documentai/v1:
- python-gapic-name=documentai
- python-gapic-namespace=google.cloud
- warehouse-package-name=google-cloud-documentai
google/cloud/documentai/v1beta3:
- python-gapic-name=documentai
- python-gapic-namespace=google.cloud
- warehouse-package-name=google-cloud-documentaiReferences
- A general rule in this repository is to keep collections sorted to improve maintainability and consistency. While the rule specifically mentions dictionary keys, the same principle applies to this list of options.
| - warehouse-package-name=google-cloud-private-catalog | ||
| - autogen-snippets | ||
| - python-gapic-namespace=google.cloud | ||
| - python-gapic-name=privatecatalog |
There was a problem hiding this comment.
For consistency and better maintainability, please sort the opt_args_by_api list alphabetically. This makes it easier to find specific options and aligns with the repository's preference for sorted collections.
- python-gapic-name=privatecatalog
- python-gapic-namespace=google.cloud
- warehouse-package-name=google-cloud-private-catalogReferences
- A general rule in this repository is to keep collections sorted to improve maintainability and consistency. While the rule specifically mentions dictionary keys, the same principle applies to this list of options.
These are equivalent to autogen-snippets=True, which is already the default.
Fixes googleapis/librarian#5525