Skip to content

chore: remove autogen-snippets options with no value #16794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jskeet merged 1 commit into from
Apr 24, 2026
+0 −3
Merged

chore: remove autogen-snippets options with no value #16794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions librarian.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1897,12 +1897,10 @@ libraries:
python:
opt_args_by_api:
google/cloud/documentai/v1:
- autogen-snippets
- python-gapic-namespace=google.cloud
- python-gapic-name=documentai
- warehouse-package-name=google-cloud-documentai
google/cloud/documentai/v1beta3:
- autogen-snippets
- python-gapic-namespace=google.cloud
- python-gapic-name=documentai
- warehouse-package-name=google-cloud-documentai
Comment on lines 1899 to 1906
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and better maintainability, please sort the opt_args_by_api lists for v1 and v1beta3 alphabetically. This makes it easier to find specific options and aligns with the repository's preference for sorted collections.

        google/cloud/documentai/v1:
          - python-gapic-name=documentai
          - python-gapic-namespace=google.cloud
          - warehouse-package-name=google-cloud-documentai
        google/cloud/documentai/v1beta3:
          - python-gapic-name=documentai
          - python-gapic-namespace=google.cloud
          - warehouse-package-name=google-cloud-documentai
References
  1. A general rule in this repository is to keep collections sorted to improve maintainability and consistency. While the rule specifically mentions dictionary keys, the same principle applies to this list of options.

Expand Down Expand Up @@ -3055,7 +3053,6 @@ libraries:
opt_args_by_api:
google/cloud/privatecatalog/v1beta1:
- warehouse-package-name=google-cloud-private-catalog
- autogen-snippets
- python-gapic-namespace=google.cloud
- python-gapic-name=privatecatalog
Comment on lines 3055 to 3057
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and better maintainability, please sort the opt_args_by_api list alphabetically. This makes it easier to find specific options and aligns with the repository's preference for sorted collections.

          - python-gapic-name=privatecatalog
          - python-gapic-namespace=google.cloud
          - warehouse-package-name=google-cloud-private-catalog
References
  1. A general rule in this repository is to keep collections sorted to improve maintainability and consistency. While the rule specifically mentions dictionary keys, the same principle applies to this list of options.

name_pretty_override: Private Catalog
Expand Down
Loading