Adds AudioEncoderConfig's aac #2306
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
I'm not sure "restore" is the right word for this kind of things, because it's never been in the libs. Maybe Add is the better word. |
| "members": { | ||
| "member": { | ||
| "aac": null, // Blink only as of 2024-09 | ||
| "flac": null // Blink only as of 2024-09 |
There was a problem hiding this comment.
Hmm actually the previous comment was wrong, Blink doesn't have flac config 🤔 and thus is now WebKit only
There was a problem hiding this comment.
LOLLLLLLLLLLLLLLLL, I will close this PR 😂
There was a problem hiding this comment.
Hmm? aac still has multiple implementations.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you very much
Bashamega
changed the title
|
I have fixed it @saschanaz |
|
(methinks people should just use opus but who am I to argue) LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
2 participants
No description provided.