Skip to content

Adds AudioEncoderConfig's aac #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 3 commits into from
Dec 21, 2025
Merged

Adds AudioEncoderConfig's aac #2306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a0cbe3
Restore AudioEncoderConfig's aac and flac
Bashamega Dec 21, 2025
9136a87
-
Bashamega Dec 21, 2025
53930dd
Swap AudioEncoderConfig and AudioContextOptions
saschanaz Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
/// Window APIs
/////////////////////////////

interface AacEncoderConfig {
format?: AacBitstreamFormat;
}

interface AddEventListenerOptions extends EventListenerOptions {
once?: boolean;
passive?: boolean;
Expand Down Expand Up @@ -146,6 +150,7 @@ interface AudioDecoderSupport {
}

interface AudioEncoderConfig {
aac?: AacEncoderConfig;
bitrate?: number;
bitrateMode?: BitrateMode;
codec: string;
Expand Down Expand Up @@ -42414,6 +42419,7 @@ type Uint32List = Uint32Array<ArrayBufferLike> | GLuint[];
type VibratePattern = number | number[];
type WindowProxy = Window;
type XMLHttpRequestBodyInit = Blob | BufferSource | FormData | URLSearchParams | string;
type AacBitstreamFormat = "aac" | "adts";
type AlignSetting = "center" | "end" | "left" | "right" | "start";
type AlphaOption = "discard" | "keep";
type AnimationPlayState = "finished" | "idle" | "paused" | "running";
Expand Down
6 changes: 6 additions & 0 deletions baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
/// Window APIs
/////////////////////////////

interface AacEncoderConfig {
format?: AacBitstreamFormat;
}

interface AddEventListenerOptions extends EventListenerOptions {
once?: boolean;
passive?: boolean;
Expand Down Expand Up @@ -143,6 +147,7 @@ interface AudioDecoderSupport {
}

interface AudioEncoderConfig {
aac?: AacEncoderConfig;
bitrate?: number;
bitrateMode?: BitrateMode;
codec: string;
Expand Down Expand Up @@ -42388,6 +42393,7 @@ type Uint32List = Uint32Array | GLuint[];
type VibratePattern = number | number[];
type WindowProxy = Window;
type XMLHttpRequestBodyInit = Blob | BufferSource | FormData | URLSearchParams | string;
type AacBitstreamFormat = "aac" | "adts";
type AlignSetting = "center" | "end" | "left" | "right" | "start";
type AlphaOption = "discard" | "keep";
type AnimationPlayState = "finished" | "idle" | "paused" | "running";
Expand Down
6 changes: 6 additions & 0 deletions baselines/ts5.5/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
/// Worker APIs
/////////////////////////////

interface AacEncoderConfig {
format?: AacBitstreamFormat;
}

interface AddEventListenerOptions extends EventListenerOptions {
once?: boolean;
passive?: boolean;
Expand Down Expand Up @@ -82,6 +86,7 @@ interface AudioDecoderSupport {
}

interface AudioEncoderConfig {
aac?: AacEncoderConfig;
bitrate?: number;
bitrateMode?: BitrateMode;
codec: string;
Expand Down Expand Up @@ -13444,6 +13449,7 @@ type Transferable = OffscreenCanvas | ImageBitmap | MessagePort | MediaSourceHan
type URLPatternInput = string | URLPatternInit;
type Uint32List = Uint32Array | GLuint[];
type XMLHttpRequestBodyInit = Blob | BufferSource | FormData | URLSearchParams | string;
type AacBitstreamFormat = "aac" | "adts";
type AlphaOption = "discard" | "keep";
type AudioSampleFormat = "f32" | "f32-planar" | "s16" | "s16-planar" | "s32" | "s32-planar" | "u8" | "u8-planar";
type AvcBitstreamFormat = "annexb" | "avc";
Expand Down
6 changes: 6 additions & 0 deletions baselines/ts5.6/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
/// Window APIs
/////////////////////////////

interface AacEncoderConfig {
format?: AacBitstreamFormat;
}

interface AddEventListenerOptions extends EventListenerOptions {
once?: boolean;
passive?: boolean;
Expand Down Expand Up @@ -143,6 +147,7 @@ interface AudioDecoderSupport {
}

interface AudioEncoderConfig {
aac?: AacEncoderConfig;
bitrate?: number;
bitrateMode?: BitrateMode;
codec: string;
Expand Down Expand Up @@ -42411,6 +42416,7 @@ type Uint32List = Uint32Array | GLuint[];
type VibratePattern = number | number[];
type WindowProxy = Window;
type XMLHttpRequestBodyInit = Blob | BufferSource | FormData | URLSearchParams | string;
type AacBitstreamFormat = "aac" | "adts";
type AlignSetting = "center" | "end" | "left" | "right" | "start";
type AlphaOption = "discard" | "keep";
type AnimationPlayState = "finished" | "idle" | "paused" | "running";
Expand Down
6 changes: 6 additions & 0 deletions baselines/ts5.6/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
/// Worker APIs
/////////////////////////////

interface AacEncoderConfig {
format?: AacBitstreamFormat;
}

interface AddEventListenerOptions extends EventListenerOptions {
once?: boolean;
passive?: boolean;
Expand Down Expand Up @@ -82,6 +86,7 @@ interface AudioDecoderSupport {
}

interface AudioEncoderConfig {
aac?: AacEncoderConfig;
bitrate?: number;
bitrateMode?: BitrateMode;
codec: string;
Expand Down Expand Up @@ -13444,6 +13449,7 @@ type Transferable = OffscreenCanvas | ImageBitmap | MessagePort | MediaSourceHan
type URLPatternInput = string | URLPatternInit;
type Uint32List = Uint32Array | GLuint[];
type XMLHttpRequestBodyInit = Blob | BufferSource | FormData | URLSearchParams | string;
type AacBitstreamFormat = "aac" | "adts";
type AlphaOption = "discard" | "keep";
type AudioSampleFormat = "f32" | "f32-planar" | "s16" | "s16-planar" | "s32" | "s32-planar" | "u8" | "u8-planar";
type AvcBitstreamFormat = "annexb" | "avc";
Expand Down
6 changes: 6 additions & 0 deletions baselines/ts5.9/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
/// Window APIs
/////////////////////////////

interface AacEncoderConfig {
format?: AacBitstreamFormat;
}

interface AddEventListenerOptions extends EventListenerOptions {
once?: boolean;
passive?: boolean;
Expand Down Expand Up @@ -143,6 +147,7 @@ interface AudioDecoderSupport {
}

interface AudioEncoderConfig {
aac?: AacEncoderConfig;
bitrate?: number;
bitrateMode?: BitrateMode;
codec: string;
Expand Down Expand Up @@ -42411,6 +42416,7 @@ type Uint32List = Uint32Array<ArrayBufferLike> | GLuint[];
type VibratePattern = number | number[];
type WindowProxy = Window;
type XMLHttpRequestBodyInit = Blob | BufferSource | FormData | URLSearchParams | string;
type AacBitstreamFormat = "aac" | "adts";
type AlignSetting = "center" | "end" | "left" | "right" | "start";
type AlphaOption = "discard" | "keep";
type AnimationPlayState = "finished" | "idle" | "paused" | "running";
Expand Down
6 changes: 6 additions & 0 deletions baselines/ts5.9/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
/// Worker APIs
/////////////////////////////

interface AacEncoderConfig {
format?: AacBitstreamFormat;
}

interface AddEventListenerOptions extends EventListenerOptions {
once?: boolean;
passive?: boolean;
Expand Down Expand Up @@ -82,6 +86,7 @@ interface AudioDecoderSupport {
}

interface AudioEncoderConfig {
aac?: AacEncoderConfig;
bitrate?: number;
bitrateMode?: BitrateMode;
codec: string;
Expand Down Expand Up @@ -13444,6 +13449,7 @@ type Transferable = OffscreenCanvas | ImageBitmap | MessagePort | MediaSourceHan
type URLPatternInput = string | URLPatternInit;
type Uint32List = Uint32Array<ArrayBufferLike> | GLuint[];
type XMLHttpRequestBodyInit = Blob | BufferSource | FormData | URLSearchParams | string;
type AacBitstreamFormat = "aac" | "adts";
type AlphaOption = "discard" | "keep";
type AudioSampleFormat = "f32" | "f32-planar" | "s16" | "s16-planar" | "s32" | "s32-planar" | "u8" | "u8-planar";
type AvcBitstreamFormat = "annexb" | "avc";
Expand Down
6 changes: 6 additions & 0 deletions baselines/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
/// Worker APIs
/////////////////////////////

interface AacEncoderConfig {
format?: AacBitstreamFormat;
}

interface AddEventListenerOptions extends EventListenerOptions {
once?: boolean;
passive?: boolean;
Expand Down Expand Up @@ -85,6 +89,7 @@ interface AudioDecoderSupport {
}

interface AudioEncoderConfig {
aac?: AacEncoderConfig;
bitrate?: number;
bitrateMode?: BitrateMode;
codec: string;
Expand Down Expand Up @@ -13447,6 +13452,7 @@ type Transferable = OffscreenCanvas | ImageBitmap | MessagePort | MediaSourceHan
type URLPatternInput = string | URLPatternInit;
type Uint32List = Uint32Array<ArrayBufferLike> | GLuint[];
type XMLHttpRequestBodyInit = Blob | BufferSource | FormData | URLSearchParams | string;
type AacBitstreamFormat = "aac" | "adts";
type AlphaOption = "discard" | "keep";
type AudioSampleFormat = "f32" | "f32-planar" | "s16" | "s16-planar" | "s32" | "s32-planar" | "u8" | "u8-planar";
type AvcBitstreamFormat = "annexb" | "avc";
Expand Down
1 change: 0 additions & 1 deletion inputfiles/removedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@
"AudioEncoderConfig": {
"members": {
"member": {
"aac": null, // Blink only as of 2024-09
"flac": null // Blink only as of 2024-09
Copy link
Collaborator

@saschanaz saschanaz Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm actually the previous comment was wrong, Blink doesn't have flac config 🤔 and thus is now WebKit only

Copy link
Contributor Author

@Bashamega Bashamega Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOLLLLLLLLLLLLLLLL, I will close this PR 😂

Copy link
Collaborator

@saschanaz saschanaz Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm? aac still has multiple implementations.

Copy link
Collaborator

@saschanaz saschanaz Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can go ahead in https://searchfox.org/wubkat/search?q=AudioEncoderConfig&path=.idl&case=false&regexp=false and https://source.chromium.org/search?q=AudioEncoderConfig%20file:idl%20path:third_party%2Fblink%2Frenderer&sq= to check it yourself

Copy link
Contributor Author

@Bashamega Bashamega Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

}
}
Expand Down