PYTHON-3124 Remove overlapping slots from _WriteResult subclasses - #884
Merged
Conversation
ariebovenberg
requested review from
ShaneHarvey,
blink1073 and
juliusgeo
as code owners
February 20, 2022 14:58
Contributor
Author
|
Hmmm, some test failures. The test logs appears to be behind corp.mongodb.com, which I don't have access to. I doubt that this |
ariebovenberg
changed the title
ariebovenberg
changed the title
Contributor
|
@ariebovenberg I took a look at the tests and they appear to be random failures. However, they are only happening with Auth+SSL, so I have restarted those failing tests to see if they pass once restarted. |
ShaneHarvey
approved these changes
Feb 22, 2022
ShaneHarvey
left a comment
ShaneHarvey
left a comment
Contributor
There was a problem hiding this comment.
LGTM, the test failures are unrelated.
Contributor
|
Thanks @ariebovenberg! |
blink1073
pushed a commit
to blink1073/mongo-python-driver
that referenced
this pull request
Feb 25, 2022
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in PYTHON-3124, there were some overlapping slots in
_WriteResultsubclasses.Tests?
I see there have been several
__slots__issues in pymongo in the past. I discovered this slot issue with slotscheck, a tool I maintain. If you like, I can add it to CI as I've done for instagram/LibCST, sqlalchemy/sqlalchemy, and aio-libs/aiohttp.