Skip to content

PYTHON-3124 Remove overlapping slots from _WriteResult subclasses #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShaneHarvey merged 1 commit into from
Feb 22, 2022
Merged

PYTHON-3124 Remove overlapping slots from _WriteResult subclasses #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/contributors.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,4 @@ The following is a list of people who have contributed to
- Khanh Nguyen (KN99HN)
- Henri Froese (henrifroese)
- Ishmum Jawad Khan (ishmum123)
- Arie Bovenberg (ariebovenberg)
10 changes: 5 additions & 5 deletions pymongo/results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def acknowledged(self) -> bool:
class InsertOneResult(_WriteResult):
"""The return type for :meth:`~pymongo.collection.Collection.insert_one`."""

__slots__ = ("__inserted_id", "__acknowledged")
__slots__ = ("__inserted_id",)

def __init__(self, inserted_id: Any, acknowledged: bool) -> None:
self.__inserted_id = inserted_id
Expand All @@ -74,7 +74,7 @@ def inserted_id(self) -> Any:
class InsertManyResult(_WriteResult):
"""The return type for :meth:`~pymongo.collection.Collection.insert_many`."""

__slots__ = ("__inserted_ids", "__acknowledged")
__slots__ = ("__inserted_ids",)

def __init__(self, inserted_ids: List[Any], acknowledged: bool) -> None:
self.__inserted_ids = inserted_ids
Expand All @@ -98,7 +98,7 @@ class UpdateResult(_WriteResult):
:meth:`~pymongo.collection.Collection.replace_one`.
"""

__slots__ = ("__raw_result", "__acknowledged")
__slots__ = ("__raw_result",)

def __init__(self, raw_result: Dict[str, Any], acknowledged: bool) -> None:
self.__raw_result = raw_result
Expand Down Expand Up @@ -136,7 +136,7 @@ class DeleteResult(_WriteResult):
"""The return type for :meth:`~pymongo.collection.Collection.delete_one`
and :meth:`~pymongo.collection.Collection.delete_many`"""

__slots__ = ("__raw_result", "__acknowledged")
__slots__ = ("__raw_result",)

def __init__(self, raw_result: Dict[str, Any], acknowledged: bool) -> None:
self.__raw_result = raw_result
Expand All @@ -157,7 +157,7 @@ def deleted_count(self) -> int:
class BulkWriteResult(_WriteResult):
"""An object wrapper for bulk API write results."""

__slots__ = ("__bulk_api_result", "__acknowledged")
__slots__ = ("__bulk_api_result",)

def __init__(self, bulk_api_result: Dict[str, Any], acknowledged: bool) -> None:
"""Create a BulkWriteResult instance.
Expand Down