chore(deps): drop unused ioredis from desktop-ui - #335
Merged
Conversation
`ioredis` is declared in apps/desktop-ui but never imported anywhere in the tree. Redis Commander does not use it: Redis access goes through the Rust `redis` crate (apps/desktop/src-tauri/Cargo.toml), routed via /api/redis-commander/* in src/dbtools/redis_tool.rs. A Node Redis client also could not work in this product — the desktop app is fully offline with no server, and all data goes through Tauri local_api. Removing it drops ioredis and its exclusive transitive deps (cluster-key-slot, denque, redis-errors, redis-parser, standard-as-callback) from the lockfile. Nothing is added. This also supersedes the ioredis 5 -> 6 major bump in #331: no reason to take a breaking upgrade on a dependency nothing imports. Verified: tsc --noEmit clean in both apps, jest 139/139 suites and 1312 tests passing, and a full `next build` of desktop-ui succeeds (the last is not covered by CI, which never builds desktop-ui). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ThreatCrush Security Scan1 finding(s) MEDIUM: 1
Snippets are redacted; ThreatCrush never prints matched credential material. |
itsmeakhil
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #331 (ioredis 5 → 6).
ioredisis declared in apps/desktop-ui/package.json but never imported anywhere in the tree — the only occurrence of the string in any source file is the dependency line itself.Redis Commander does not use it. Redis access goes through the Rust
rediscrate (Cargo.toml:45), routed via/api/redis-commander/*insrc/dbtools/redis_tool.rs. A Node Redis client could not work in this product anyway: the desktop app is fully offline with no server, and all data goes through Taurilocal_api.So rather than take a breaking major on a dependency nothing imports, this removes it.
What changes
Removes
ioredisand its exclusive transitive deps from the lockfile —cluster-key-slot,denque,redis-errors,redis-parser,standard-as-callback. Nothing is added (55 lockfile lines deleted, 0 inserted).Verification
tsc --noEmitdesktop-uitsc --noEmitwebjest --cidesktop-uinext builddesktop-uiThe
next buildmatters here: ci.yml only typechecks and tests desktop-ui, it never builds it — a desktop-ui build otherwise happens for the first time during a real release. I ran it locally to close that gap.🤖 Generated with Claude Code