Fix linting in CELLRANGER_MULTI#10138
Merged
LouisLeNezet merged 3 commits intonf-core:masterfrom Feb 24, 2026
Merged
Conversation
LouisLeNezet
changed the title
CELLRANGER_MULTI
SPPearce
reviewed
Feb 24, 2026
|
|
||
| // the feature barcodes section get options for either CRISPR or antibody capture assays | ||
| fb_options = meta_ab?.options ? meta_ab.options : (meta_crispr?.options ? meta_crispr.options : []) | ||
| fb_options = ab_fastqs.first().getName() != 'fastqs' && meta_ab?.options ? meta_ab : |
Contributor
There was a problem hiding this comment.
My brain can't figure out what is going on here.
Contributor
Author
There was a problem hiding this comment.
I've updated it to match #9803
The aim of this option is to copy the meta map of ab_fatsqs if exist or the one from crispr and if none set it to empty.
I've just wrote it in a way consistent to the rest of the module.
I have to admit that this module is quite huge (maybe too much) and it's complicated to know what does what.
Contributor
There was a problem hiding this comment.
Definitely agree that this module is hard to understand.
Contributor
Author
There was a problem hiding this comment.
So, what should we do ?
SPPearce
approved these changes
Feb 24, 2026
Contributor
SPPearce
left a comment
SPPearce
left a comment
There was a problem hiding this comment.
Approve for now, and leave it for other people to worry about ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda