Add module: sylph/query#12399
Merged
Merged
Conversation
Contributor
|
Please join the nf-core github org via the slack channel so the CI runs for you. |
Contributor
Author
|
@mashehu thank you, I can see you have added me to the org as well! |
mashehu
reviewed
Jul 22, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
nghiaagent
force-pushed
the
new_sylphquery
branch
from
July 23, 2026 00:30
fc064f7 to
ffc072b
Compare
Contributor
Author
|
I applied the requested changes and merged from upstream. nf-test with Docker worked locally. @mashehu some of the changes you suggested are also in the remaining sylph modules, should I go adjust them as well in another issue after this is done? |
mashehu
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module adds the query command from sylph. It accepts inputs similar to
sylph profile, but instead of returning the metagenomic profile of a sample, it returns cANI estimates per detected genome in a sample.PR checklist
Closes #12396
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda