Skip to content

Add module: sylph/query#12399

Merged
nghiaagent merged 9 commits into
nf-core:masterfrom
nghiaagent:new_sylphquery
Jul 24, 2026
Merged

Add module: sylph/query#12399
nghiaagent merged 9 commits into
nf-core:masterfrom
nghiaagent:new_sylphquery

Conversation

@nghiaagent

Copy link
Copy Markdown
Contributor

This module adds the query command from sylph. It accepts inputs similar to sylph profile, but instead of returning the metagenomic profile of a sample, it returns cANI estimates per detected genome in a sample.

PR checklist

Closes #12396

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@nghiaagent nghiaagent changed the title First commit Add module: sylph/query Jul 22, 2026
@mashehu

mashehu commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Please join the nf-core github org via the slack channel so the CI runs for you.

@nghiaagent

Copy link
Copy Markdown
Contributor Author

@mashehu thank you, I can see you have added me to the org as well!

Comment thread modules/nf-core/sylph/query/meta.yml Outdated
Comment thread modules/nf-core/sylph/query/main.nf Outdated
Comment thread modules/nf-core/sylph/query/meta.yml Outdated
nghiaagent and others added 8 commits July 22, 2026 20:22
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@nghiaagent

Copy link
Copy Markdown
Contributor Author

I applied the requested changes and merged from upstream. nf-test with Docker worked locally. @mashehu some of the changes you suggested are also in the remaining sylph modules, should I go adjust them as well in another issue after this is done?

@nghiaagent
nghiaagent requested a review from mashehu July 23, 2026 11:03
@nghiaagent
nghiaagent added this pull request to the merge queue Jul 24, 2026
Merged via the queue into nf-core:master with commit 620983b Jul 24, 2026
26 checks passed
@nghiaagent
nghiaagent deleted the new_sylphquery branch July 24, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: sylph/query

2 participants