Skip to content

Conversation

@caiohamamura
Copy link

@caiohamamura caiohamamura commented Aug 28, 2025

Probably fixes most TLS (https) issues #2970 #1707 #1484.

  • This PR is for the dev branch rather than for the release branch.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

This will add SNI support for secure connections by providing these modifications:

@caiohamamura
Copy link
Author

caiohamamura commented Aug 28, 2025

I just pushed commits for extending SNI support for MMQT and Websockets 4bf7acd

@marcelstoer
Copy link
Member

Sorry, please rebase on dev - my bad.

@caiohamamura
Copy link
Author

Rebase done!

Copy link
Member

@jmattsson jmattsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great addition!
Just one comment around some debug prints, but otherwise a big thumbs up from me 👍 (with the caveat I haven't looked at the 8266 branch in years 😅)

@jmattsson
Copy link
Member

jmattsson commented Aug 30, 2025 via email

@marcelstoer marcelstoer merged commit 68c6072 into nodemcu:dev Aug 30, 2025
17 of 18 checks passed
@caiohamamura caiohamamura deleted the sni_tls branch August 30, 2025 11:33
@marcelstoer
Copy link
Member

marcelstoer commented Aug 30, 2025

@caiohamamura This is gold, thank you!

I just went through a pile of old HTTPS issues (you linked to some of them) and tested the URLs we were testing back then. Just sending HTTP GET to them through our http module. The only ones that still don't work:

The output is always the same and I'm sure it's totally unrelated to what this PR fixes. Didn't investigate further, though.

HTTP client: Disconnected with error: -114
HTTP client: Connection timeout
HTTP request failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants