Skip to content

Backport explore, search, and alerts lazy-loading updates to 1.13#30135

Open
shah-harshit wants to merge 1 commit into
ui/backport-group13-database-schema-container-lazy-1.13from
ui/backport-group14-explore-search-alerts-lazy-1.13
Open

Backport explore, search, and alerts lazy-loading updates to 1.13#30135
shah-harshit wants to merge 1 commit into
ui/backport-group13-database-schema-container-lazy-1.13from
ui/backport-group14-explore-search-alerts-lazy-1.13

Conversation

@shah-harshit

@shah-harshit shah-harshit commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Stack

Testing

  • Scoped UI checkstyle sequence on changed source files: organize-imports-cli, ESLint --fix, Prettier.
  • git diff --check HEAD~1..HEAD

Greptile Summary

This PR splits pure utility functions from larger UI utility modules to improve lazy loading. The main changes are:

  • Direct pure-module imports for explore, search, alerts, feeds, and query builders.
  • Removed compatibility re-exports from the original utility modules.
  • Updated component tests and mocks for the new module boundaries.

Confidence Score: 4/5

The stale advanced-search import breaks the UI build and needs to be fixed before merging.

  • QuickFilterDropdown.tsx imports a symbol removed from AdvancedSearchUtils.tsx.
  • The other inspected direct imports resolve to matching pure-module exports.
  • Updated tests generally mock the new module paths correctly.

openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchUtils.tsx and openmetadata-ui/src/main/resources/ui/src/components/Explore/QuickFilterDropdown.tsx

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchUtils.tsx Removes pure utility re-exports, but an unchanged component still imports one of them from this module.
openmetadata-ui/src/main/resources/ui/src/utils/Alerts/AlertsUtil.tsx Removes pure alert utility re-exports and keeps inspected consumers aligned with the new module boundary.
openmetadata-ui/src/main/resources/ui/src/utils/ExploreUtils.tsx Moves inspected pure explore consumers to ExplorePureUtils without changing their implementations.
openmetadata-ui/src/main/resources/ui/src/utils/QueryBuilderUtils.tsx Narrows the facade to rendering behavior while components and tests use QueryBuilderPureUtils directly.
openmetadata-ui/src/main/resources/ui/src/utils/SearchUtils.tsx Removes search-function re-exports and redirects inspected callers to SearchPureUtils.

Comments Outside Diff (1)

  1. openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchUtils.tsx, line 42-54 (link)

    P1 Removed Export Breaks UI Build

    QuickFilterDropdown.tsx still imports getSelectedOptionLabelString from this module. Removing its re-export makes that unchanged component fail TypeScript/Webpack compilation with a missing-export error; migrate that importer to AdvancedSearchPureUtils or retain the compatibility export.

    Context Used: CLAUDE.md (source)

Reviews (1): Last reviewed commit: "feat(ui): update Explore, Search & Alert..." | Re-trigger Greptile

Context used:

  • Context used - CLAUDE.md (source)
  • Context used - openmetadata-ui-core-components/CLAUDE.md (source)

…ility pattern (#29068)

* feat(ui): update Explore, Search & Alerts components for lazy-load utility pattern

Updates Explore, Search and Alerts components to import from extracted pure utility modules. Updates AdvancedSearchUtils, SearchUtils, ExploreUtils imports. Updates AlertsUtil and QueryBuilderUtils for consistent utility usage.

Ref: open-metadata/openmetadata-collate#4230

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix test

* fix build, checkstyle and tests

* fix import

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
@shah-harshit
shah-harshit requested a review from a team as a code owner July 16, 2026 09:48
@shah-harshit shah-harshit added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check labels Jul 16, 2026
@shah-harshit shah-harshit self-assigned this Jul 16, 2026
@gitar-bot

gitar-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Backports explore, search, and alerts components to use the lazy-loading utility pattern. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant