Backport explore, search, and alerts lazy-loading updates to 1.13#30135
Open
shah-harshit wants to merge 1 commit into
Conversation
…ility pattern (#29068) * feat(ui): update Explore, Search & Alerts components for lazy-load utility pattern Updates Explore, Search and Alerts components to import from extracted pure utility modules. Updates AdvancedSearchUtils, SearchUtils, ExploreUtils imports. Updates AlertsUtil and QueryBuilderUtils for consistent utility usage. Ref: open-metadata/openmetadata-collate#4230 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix test * fix build, checkstyle and tests * fix import --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Code Review ✅ ApprovedBackports explore, search, and alerts components to use the lazy-loading utility pattern. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Testing
Greptile Summary
This PR splits pure utility functions from larger UI utility modules to improve lazy loading. The main changes are:
Confidence Score: 4/5
The stale advanced-search import breaks the UI build and needs to be fixed before merging.
QuickFilterDropdown.tsximports a symbol removed fromAdvancedSearchUtils.tsx.openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchUtils.tsx and openmetadata-ui/src/main/resources/ui/src/components/Explore/QuickFilterDropdown.tsx
Important Files Changed
Comments Outside Diff (1)
openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchUtils.tsx, line 42-54 (link)QuickFilterDropdown.tsxstill importsgetSelectedOptionLabelStringfrom this module. Removing its re-export makes that unchanged component fail TypeScript/Webpack compilation with a missing-export error; migrate that importer toAdvancedSearchPureUtilsor retain the compatibility export.Context Used: CLAUDE.md (source)
Reviews (1): Last reviewed commit: "feat(ui): update Explore, Search & Alert..." | Re-trigger Greptile
Context used: