Skip to content

Update severity levels: Info→Low, Warning→Moderate, Major→Important - #428

Open
joshbranham wants to merge 1 commit into
openshift:masterfrom
joshbranham:update-severity-levels
Open

Update severity levels: Info→Low, Warning→Moderate, Major→Important#428
joshbranham wants to merge 1 commit into
openshift:masterfrom
joshbranham:update-severity-levels

Conversation

@joshbranham

@joshbranham joshbranham commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Rename severity values across all 198 notification templates to align with the updated severity taxonomy. Update checkseverity.sh error message to reflect the new valid values.

Summary by CodeRabbit

  • New Features
    • Updated alert and event severity labels across hosted control plane, managed service, and ROSA notifications.
    • Notifications now consistently use Debug, Low, Moderate, Important, and Critical severity levels.
  • Bug Fixes
    • Corrected severity classifications for infrastructure, installation, networking, storage, support, maintenance, and upgrade conditions.
    • Improved consistency for AWS and GCP outage, capacity, quota, and permission alerts.

Rename severity values across all 198 notification templates to align
with the updated severity taxonomy. Update checkseverity.sh error
message to reflect the new valid values.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@joshbranham joshbranham self-assigned this Aug 7, 2026
@joshbranham

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2026
@openshift-ci
openshift-ci Bot requested review from Makdaam and ravitri August 7, 2026 20:01
@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshbranham
Once this PR has been reviewed and has the lgtm label, please assign evalis1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0426170f-e025-453c-a1fc-92f4af29c742

📥 Commits

Reviewing files that changed from the base of the PR and between f838c92 and 96d5e6a.

📒 Files selected for processing (199)
  • hcp/OCPBUGS_14611_Leftover_PersistentVolume.json
  • hcp/Operator_Workload_Scheduling_Issue.json
  • hcp/RequestServingNode_resized.json
  • hcp/WorkerNodes_Stopped_error.json
  • hcp/autonode/custom_subnet_tags_missing.json
  • hcp/autonode/default_subnet_tags_missing.json
  • hcp/customer_cni_misconfiguration.json
  • hcp/end_of_support_force_upgrade.json
  • hcp/eus_transition_attempted.json
  • hcp/eus_transition_success.json
  • hcp/hcp_aws_kms_permissions_issue.json
  • hcp/ip_range_is_full.json
  • hcp/logForwarding/cloudwatch_log_group_not_found.json
  • hcp/logForwarding/cloudwatch_log_group_permission_denied.json
  • hcp/logForwarding/s3_bucket_not_found.json
  • hcp/logForwarding/s3_bucket_permission_denied.json
  • hcp/logForwarding/sre_insufficient_permissions.json
  • hcp/node_ip_range_is_full.json
  • hcp/sts_deleted_provider.json
  • hcp/webhook_blocking_nodepool_update.json
  • osd/AddonMisconfiguration.json
  • osd/AlertmanagerSilencesActiveSRE.json
  • osd/BadMachineConfigPool.json
  • osd/BadMachinePoolTaint.json
  • osd/DockerCIDROverlap45Install.json
  • osd/ElasticsearchClusterMisconfigured.json
  • osd/ElasticsearchClusterNotEnoughResources_Error.json
  • osd/ElasticsearchClusterNotHealthy_Error.json
  • osd/ElasticsearchClusterNotHealthy_Warning.json
  • osd/Failed_Logins.json
  • osd/InvalidCIDR.json
  • osd/KubePersistentVolumeFillingUpError-user.json
  • osd/KubePersistentVolumeFillingUpError.json
  • osd/KubePersistentVolumeFillingUpWarn.json
  • osd/MultipleDefaultStorageClasses.json
  • osd/Multiple_OCPBUGs_install_failure.json
  • osd/NetworkMigrationBlocked.json
  • osd/NetworkMisconfiguration.json
  • osd/NodeFilesystemSpaceFillingUp-worker.json
  • osd/Non_Red_Hat_Access_Core_Secrets.json
  • osd/Non_System_Change_SRE_API_Endpoint.json
  • osd/OCM3018_rosa_STS_machine_api_role.json
  • osd/OCPBUGS-16655-remediation-please-upgrade.json
  • osd/OCPBUGS6494_4_12_install_failure.json
  • osd/OCPBUG_install_failure.json
  • osd/OperatorMisconfigured.json
  • osd/PlatformComponentNonRedHat.json
  • osd/RHOAMInstallNeedsMoreResources.json
  • osd/RecoveryOfDeletedMaster.json
  • osd/ResourceIsRaisingClusterAlert.json
  • osd/RosaInstallationFailedOnInvalidIamRoles.json
  • osd/StuckNewBuilds3MinSRE.json
  • osd/User_Forbidden.json
  • osd/aws/AWS_outage.json
  • osd/aws/AWS_zone_outage.json
  • osd/aws/AddressLimitExceeded.json
  • osd/aws/AlertmanagerSilencesActiveSRE.json
  • osd/aws/GenericQuotaExceeded.json
  • osd/aws/InstallFailed_AWSS3Change.json
  • osd/aws/InstallFailed_AWS_Capacity.json
  • osd/aws/InstallFailed_BucketRequestRateTooHigh.json
  • osd/aws/InstallFailed_CreateServiceLinkedRole.json
  • osd/aws/InstallFailed_InvalidCustomTag.json
  • osd/aws/InstallFailed_InvalidDHCPOptionset.json
  • osd/aws/InstallFailed_InvalidSubnet.json
  • osd/aws/InstallFailed_MultipleRoute53ZonesFound.json
  • osd/aws/InstallFailed_NATGatewayPrivateSubnet.json
  • osd/aws/InstallFailed_NetworkMisconfigured.json
  • osd/aws/InstallFailed_NetworkMisconfigured_Generic.json
  • osd/aws/InstallFailed_NetworkMisconfigured_PrivateLink.json
  • osd/aws/InstallFailed_NoRouteToInternet.json
  • osd/aws/InstallFailed_PrivateLink_Firewall.json
  • osd/aws/InstallFailed_PrivateLink_subnetEgress.json
  • osd/aws/InstallFailed_ProxyBadTLS.json
  • osd/aws/InstallFailed_QuotaExceeded.json
  • osd/aws/InstallFailed_RoleDeletionFailed.json
  • osd/aws/InstallFailed_STS_PrivateLink.json
  • osd/aws/InstallFailed_SecurityGroupBeingModified.json
  • osd/aws/InstallFailed_TempAWSError.json
  • osd/aws/InstallFailed_TooManyBucketObjectTags.json
  • osd/aws/InstallFailed_TooManyBuckets.json
  • osd/aws/InstallFailed_lambda_automation_interfering.json
  • osd/aws/InstallFailed_proxy_unreachable.json
  • osd/aws/NodeStuckTerminating.json
  • osd/aws/ROSA_AWS_KMS_permissions_required.json
  • osd/aws/ROSA_AWS_invalid_permissions.json
  • osd/aws/ROSA_AWS_invalid_permissions_with_reason.json
  • osd/aws/SubnetAddressRangeFull.json
  • osd/aws/TagPolicyBlocksInstanceCreation.json
  • osd/aws/VPCEndpointLimitExceeded.json
  • osd/aws/VPCLimitExceeded.json
  • osd/aws/aws_outage_resolved.json
  • osd/aws/sts_thumbprint.json
  • osd/aws/unable_to_create_machines_aws_capacity.json
  • osd/cluster-wide_proxy_ca_expiring.json
  • osd/cluster_alerting_with_no_sre_access.json
  • osd/cluster_cannot_be_recovered.json
  • osd/cluster_overloaded.json
  • osd/cluster_proxy_misconfiguration.json
  • osd/cluster_stuck.json
  • osd/clustertransfer_completed.json
  • osd/clustertransfer_starting.json
  • osd/controlplane_resized.json
  • osd/custom_ingress_controller_misconfiguration.json
  • osd/customer_alert_blocking_upgrade.json
  • osd/customer_alert_paging.json
  • osd/customer_clusteroperator_down.json
  • osd/customer_emptydir_storage_preventing_drain.json
  • osd/customer_pdb_preventing_drain.json
  • osd/customer_pdb_preventing_drain_automated.json
  • osd/customer_pod_preventing_drain.json
  • osd/customer_pods_preventing_drain_automated.json
  • osd/customer_stopped_control_plane_node.json
  • osd/eol_date_extended.json
  • osd/gcp/GCP_Network_Misconfig.json
  • osd/gcp/GCP_Service_API_Disabled.json
  • osd/gcp/GCP_WIF_invalid_permissions.json
  • osd/gcp/GCP_WIF_invalid_support_role.json
  • osd/gcp/GCP_infranode_resized_auto.json
  • osd/gcp/GCP_outage.json
  • osd/gcp/GCP_outage_resolved.json
  • osd/gcp/GPC_WIF_update_configuration.json
  • osd/gcp/GenericQuotaExceeded.json
  • osd/gcp/InstallFailed_GCP_Capacity.json
  • osd/gcp/InstallFailed_OCPBUGS-43821.json
  • osd/gcp/InstallFailed_QuotaExceeded.json
  • osd/gcp/invalid_iaas_credentials.json
  • osd/gcp/unable_to_create_machine_invalid_type.json
  • osd/generic_deprovision_failed.json
  • osd/generic_install_failed.json
  • osd/hive_migration.json
  • osd/idp_has_connectivity_problems.json
  • osd/ignore_previous_message.json
  • osd/incident_declared.json
  • osd/incident_resolved.json
  • osd/incident_update.json
  • osd/incorrect_PodDisruptionBudget.json
  • osd/infranode_resized.json
  • osd/infranode_resized_auto.json
  • osd/infranode_volume_type_changed.json
  • osd/install_failed_please_retry.json
  • osd/invalid_customer_ic.json
  • osd/invalid_iaas_credentials.json
  • osd/invalid_iam_role.json
  • osd/invalid_ingress_component_route.json
  • osd/invalid_registry_policy.json
  • osd/limited_support/EOLClusterStillSupported.json
  • osd/limited_support/EOLExtension.json
  • osd/limited_support/GovcloudLimitedSupportOneClusterPerVPC.json
  • osd/limited_support/LimitedSupportCloud.json
  • osd/limited_support/LimitedSupportCluster.json
  • osd/limited_support/egressFailureLimitedSupport.json
  • osd/limited_support/scheduled_chaos_test.json
  • osd/maintenance_completed.json
  • osd/maintenance_starting.json
  • osd/monitoring_stack_broken.json
  • osd/no_resources_to_run_userworkloadmonitoring.json
  • osd/obo_deprecation.json
  • osd/obo_post_deprecation.json
  • osd/osd_too_old_upgrade_needed.json
  • osd/persistentvolume_resized.json
  • osd/pipelines_resource_problem.json
  • osd/pull_secret_change_breaking_upgradesync.json
  • osd/pull_secret_multiple_sync_failures.json
  • osd/pull_secret_rotated.json
  • osd/pull_secret_user_mismatch.json
  • osd/recovered_master_node.json
  • osd/request_customer_managed_ingress.json
  • osd/required_network_egresses_are_blocked.json
  • osd/rosa_STS_invalid_permissions.json
  • osd/rosa_cert_signed_by_unknown_authority.json
  • osd/rosa_cluster_cannot_be_recovered.json
  • osd/rosa_cluster_cant_manage_instances.json
  • osd/rosa_cluster_destroyed_cluster_admin.json
  • osd/rosa_clusterlogging_general.json
  • osd/rosa_clusterlogging_loki.json
  • osd/rosa_customer_pdb_preventing_drain.json
  • osd/rosa_invalid_tls_cert.json
  • osd/rosa_no_egress_route.json
  • osd/rosa_scp_misconfigured_invalid_permission.json
  • osd/sdn_to_ovn_migration_investigation.json
  • osd/security_update_available.json
  • osd/silence_namespace_alerts_notice.json
  • osd/termination_protection.json
  • osd/unable_to_create_machine_invalid_type.json
  • osd/unevictable_workload.json
  • osd/unknown_failure.json
  • osd/unschedulable_customer_pod.json
  • osd/upgrade_blocked.json
  • osd/upgrade_blocked_with_docs.json
  • osd/upgrade_cluster_version.json
  • osd/upgrade_paused_acknowledgement.json
  • osd/uwm_misconfiguration.json
  • osd/validating_webhook_configurations.json
  • osd/workernode_overloaded.json
  • osd/workernode_overloaded_pid_limit_rosa.json
  • osd/workload_deployed_in_restricted_project.json
  • rosa/PlatformComponentNonRedHat.json
  • scripts/checkseverity.sh

Walkthrough

The pull request replaces legacy severity values across HCP, OSD, and ROSA JSON definitions. It also updates scripts/checkseverity.sh to validate Debug, Low, Moderate, Important, and Critical.

Changes

Severity vocabulary migration

Layer / File(s) Summary
Severity validation contract
scripts/checkseverity.sh
The validation script now accepts Low, Moderate, and Important instead of Info, Warning, and Major.
HCP severity values
hcp/*.json
HCP alert, issue, event, and configuration definitions update their severity values.
OSD severity values
osd/*.json, osd/limited_support/*.json
OSD definitions update alert, event, incident, support, upgrade, and configuration severities.
Provider-specific severity values
osd/aws/*.json, osd/gcp/*.json
AWS and GCP definitions update outage, installation, quota, network, permission, and capacity severities.
ROSA severity values
rosa/*.json, osd/rosa_*.json
ROSA definitions update platform and cluster-related severity values.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the severity taxonomy changes applied across the notification templates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes 198 JSON templates and one shell script; it adds no test files or Ginkgo declarations, so no test title can be unstable.
Test Structure And Quality ✅ Passed The commit changes only 198 JSON templates and checkseverity.sh; no Ginkgo test files, test paths, or Ginkgo references were found, so these requirements are not applicable.
Microshift Test Compatibility ✅ Passed The PR adds no Ginkgo tests or test-like files; it only changes 198 JSON severity fields and the severity validator, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The patch changes only 198 JSON severity fields and one shell validation message; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The parent diff contains 198 JSON severity-only edits and one validation-script edit; no deployment, operator, controller, or scheduling constraints were modified.
Ote Binary Stdout Contract ✅ Passed The patch changes only 198 JSON severity fields and one shell validation message; the repository has no OTE binary, Ginkgo, klog, or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The patch changes 198 JSON severity fields and one shell validation message; it adds no Ginkgo tests or networking code.
No-Weak-Crypto ✅ Passed The PR changes only 198 JSON severity values and two validator lines; patch searches found no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto, or secret-comparison additions.
Container-Privileges ✅ Passed The commit changes only severity values in 198 JSON files and the checker script; scans found no privileged:true, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only 198 JSON severity fields and fixed severity-validation text; no new passwords, tokens, PII, customer data, or sensitive logging behavior was added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@joshbranham

Copy link
Copy Markdown
Contributor Author

This is blocked on a rollout by SRE on September 28th.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@joshbranham: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/checklinks-pr 96d5e6a link false /test checklinks-pr

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant