setup assisted-installer version v2.55#82453
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
WalkthroughAdds four generated OpenShift CI operator configurations for Assisted v2.55 components, covering pinned base images, repository builds, promotion, resource defaults, lint and unit checks, subsystem validation, e2e scenarios, and generated metadata. ChangesAssisted v2.55 CI configurations
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
A total of 53 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@danmanor: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml (1)
116-130: 🚀 Performance & Scalability | 🔵 TrivialHardcoded
:latestimage tags for ARM day2 workers.
e2e-metal-assisted-day2-arm-workerspinsAGENT_DOCKER_IMAGE,CONTROLLER_IMAGE, andINSTALLER_IMAGEto:latesttags on a separate Konflux registry, rather than the versionedbase_images/promotion images used by the rest of this config. Mutable:latesttags can change underneath the test, causing flakiness unrelated to the code under test.If this mirrors an existing pattern from prior version bumps of this file (e.g. because ARM day2 support is only available via
ds-mainbuilds), this is likely intentional — please confirm.[reliability_and_availability_not_a_category]
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml` around lines 116 - 130, Replace the mutable :latest tags in the e2e-metal-assisted-day2-arm-workers environment with immutable, versioned promotion or base_images references consistent with the surrounding configuration, while preserving the ARM-specific ds-main image source if required by the existing version-bump pattern. Update AGENT_DOCKER_IMAGE, CONTROLLER_IMAGE, and INSTALLER_IMAGE only.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml`:
- Around line 1-29: Add assisted-test-infra-internal to the base_images section
of the v2.55 configuration, matching the name, namespace, and tag values used by
the other v2.55 assisted configurations so the shared assisted-vsphere workflow
can resolve the image.
---
Nitpick comments:
In
`@ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yaml`:
- Around line 116-130: Replace the mutable :latest tags in the
e2e-metal-assisted-day2-arm-workers environment with immutable, versioned
promotion or base_images references consistent with the surrounding
configuration, while preserving the ARM-specific ds-main image source if
required by the existing version-bump pattern. Update AGENT_DOCKER_IMAGE,
CONTROLLER_IMAGE, and INSTALLER_IMAGE only.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 60dd77bd-a4e6-42c4-98c9-0005171b4bc5
⛔ Files ignored due to path filters (8)
ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-image-service/openshift-assisted-image-service-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.55-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-v2.55-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/assisted-image-service/openshift-assisted-image-service-v2.55.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yamlci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yamlci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml
| base_images: | ||
| assisted-image-service: | ||
| name: v2.55 | ||
| namespace: edge-infrastructure | ||
| tag: assisted-image-service | ||
| assisted-installer: | ||
| name: v2.55 | ||
| namespace: edge-infrastructure | ||
| tag: assisted-installer | ||
| assisted-installer-agent: | ||
| name: v2.55 | ||
| namespace: edge-infrastructure | ||
| tag: assisted-installer-agent | ||
| assisted-installer-controller: | ||
| name: v2.55 | ||
| namespace: edge-infrastructure | ||
| tag: assisted-installer-controller | ||
| assisted-test-infra: | ||
| name: backplane-5.0 | ||
| namespace: edge-infrastructure | ||
| tag: assisted-test-infra | ||
| dev-scripts: | ||
| name: test | ||
| namespace: ocp-kni | ||
| tag: dev-scripts | ||
| upi-installer: | ||
| name: "5.0" | ||
| namespace: ocp | ||
| tag: upi-installer |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Locate relevant ci-operator configs =="
fd -a 'openshift-assisted-service-v2.55.yaml' ci-operator/config
fd -a 'openshift-assisted-service-v2.55.yaml' ci-operator/config/openshift/assisted-service
fd -a 'openshift-assisted-service-v2.55.yaml' ci-operator/config/openshift
echo
echo "== Show base_images and e2e-vsphere-assisted in target file =="
target="ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml"
wc -l "$target"
sed -n '1,70p' "$target"
echo
sed -n '210,255p' "$target"
echo
echo "== Check sibling configs for assisted-test-infra-internal and workflow usage =="
for f in \
ci-operator/config/openshift/assisted-service/openshift-assisted-image-service-v2.55.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-installer-agent-v2.55.yaml \
ci-operator/config/openshift/assisted-service/openshift-assisted-installer-v2.55.yaml
do
echo "--- $f"
rg -n 'assisted-test-infra-internal|workflow: assisted-vsphere|e2e-vsphere-assisted' "$f" || true
done
echo
echo "== Search for assisted-vsphere workflow and image reference =="
rg -n 'assisted-vsphere-setup-machine|assisted-test-infra-internal|workflow: assisted-vsphere' ci-operator/config -g '*.yaml'Repository: openshift/release
Length of output: 29783
Add assisted-test-infra-internal to base_images
e2e-vsphere-assisted uses the shared assisted-vsphere workflow, which expects assisted-test-infra-internal. The other v2.55 assisted configs already declare it, so this job can't resolve the required image without it.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/assisted-service/openshift-assisted-service-v2.55.yaml`
around lines 1 - 29, Add assisted-test-infra-internal to the base_images section
of the v2.55 configuration, matching the name, namespace, and tag values used by
the other v2.55 assisted configurations so the shared assisted-vsphere workflow
can resolve the image.
2 participants
Summary by CodeRabbit
Adds OpenShift CI configurations for the assisted-installer v2.55 release stream across:
assisted-installerassisted-installer-agentassisted-image-serviceassisted-serviceThe configurations pin component and test infrastructure images to v2.55, define repository-based image builds and promotion to
edge-infrastructure, and target OCP 5.0 nightly releases. They also establish linting, unit, subsystem, generated-code, image-publishing, and extensive bare-metal, OCI, virtualization, upgrade, and day-2 end-to-end test workflows, including scenario-specific cluster profiles and environment settings.