Skip to content

CI: multi-arch-test-build: add default packages for LuCI feed#126

Open
BKPepe wants to merge 1 commit into
openwrt:mainfrom
BKPepe:luci-repository
Open

CI: multi-arch-test-build: add default packages for LuCI feed#126
BKPepe wants to merge 1 commit into
openwrt:mainfrom
BKPepe:luci-repository

Conversation

@BKPepe

@BKPepe BKPepe commented Jun 29, 2026

Copy link
Copy Markdown
Member

Default packages for routing and telephony feeds are already present, but the LuCI feed was missing. Add it as well.

cc: @systemcrash

@github-actions

Copy link
Copy Markdown

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit 4e8c671

  • 🔶 Commit subject length: recommended max 60, required max 80 characters

For more details, see the full job log.

Something broken? Consider providing feedback.

@BKPepe

BKPepe commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

@hnyman, Hannu since you are quite active in the LuCI repo, could you please take a look? :)

@hnyman

hnyman commented Jul 2, 2026

Copy link
Copy Markdown

Sorry, no merge rights here.

@BKPepe

BKPepe commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

I do have, but I want at least someone, who will review this

@hnyman

hnyman commented Jul 2, 2026

Copy link
Copy Markdown

Not quite sure, what would be optimal.

luci-app-attendedsysupgrade has external dependencies outside LuCI. That might be unnecessary, if I understand the purpose of the default here

Simplest app for fallback default for checking non-package related changes might be luci-app-commands that has only luci-base as dependency.

@BKPepe

BKPepe commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

luci-app-attendedsysupgrade has external dependencies outside LuCI. That might be unnecessary, if I understand the purpose of the default here

Okay, I just took what was used inside the LuCi repository:
https://github.com/openwrt/luci/blob/de39fcc8d901fabfc80354484f5e66b40f9230dd/.github/workflows/build.yml#L47

Simplest app for fallback default for checking non-package related changes might be luci-app-commands that has only luci-base as dependency.

Sounds good! Thanks.

@BKPepe

BKPepe commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

@feckert What about your thoughts to use luci-app-commands?

Default packages for routing and telephony feeds are already present,
but the LuCI feed was missing. Add it as well.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Copilot AI review requested due to automatic review settings July 4, 2026 17:33
@BKPepe BKPepe force-pushed the luci-repository branch from 4e8c671 to ff01c6a Compare July 4, 2026 17:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a missing default package set for the luci feed in the multi-arch-test-build workflow so CI still builds a representative package when no packages are detected as changed.

Changes:

  • Extend the feed-to-default-packages mapping to include the luci repository.
  • Set luci-app-commands as the default fallback package for LuCI feed CI builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants