Skip to content

chore(ci): remove redundant Rstest Playwright setup - #81

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/remove-rstest-playwright-setup
Jul 31, 2026
Merged

chore(ci): remove redundant Rstest Playwright setup#81
chenjiahan merged 1 commit into
mainfrom
chenjiahan/remove-rstest-playwright-setup

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Jul 31, 2026

Copy link
Copy Markdown
Member

Important

The --with-deps experiment failed after this PR was merged. rspack (rstest) showed that ubuntu-latest lacks required WebKit libraries. Follow-up #82 restores --with-deps.

Summary

  • remove redundant Playwright Chromium installs from the Rsbuild/Rstest, Rslib/Rstest, and Rstest examples suites
  • use the Chrome channel provided by the GitHub Actions runner for Chromium coverage
  • reduce the Rspack/Rstest install from Chromium + WebKit to WebKit only

Why

Rstest selects the system Chrome channel in CI, and rstack-examples does the same after rstackjs/rstack-examples#486. This follows the cleanup in web-infra-dev/rslib#1531.

Rspack's Rstest suite still explicitly covers WebKit, so that browser must continue to be installed.

--with-deps CI experiment

This PR intentionally removed --with-deps. The long-running rspack (rstest) job reached browser-mode/webkit.test.ts after merge, then failed because ubuntu-latest was missing libgtk-4.so.1, libgraphene-1.0.so.0, libevent-2.1.so.7, Opus, and several GStreamer libraries.

The result proves WebKit still requires --with-deps; #82 restores it without reverting the safe Chromium cleanup.

Validation

  • pnpm lint
  • git diff --check
  • rsbuild (rstest), rslib (rstest), and rstest (examples) passed without installing Chromium
  • Rstest examples passed locally with GITHUB_ACTIONS=true, including all three browser-mode examples

@chenjiahan
chenjiahan marked this pull request as ready for review July 31, 2026 05:46
@chenjiahan
chenjiahan merged commit 84c8b2b into main Jul 31, 2026
22 of 23 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/remove-rstest-playwright-setup branch July 31, 2026 05:46
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 27e8ca0d-fa24-4dfe-bd2e-7e0a724c9c80

📥 Commits

Reviewing files that changed from the base of the PR and between 4b0ec85 and b5ebedc.

📒 Files selected for processing (4)
  • tests/rsbuild/rstest.ts
  • tests/rslib/rstest.ts
  • tests/rspack/rstest.ts
  • tests/rstest/examples.ts

📝 Walkthrough

Walkthrough

The test configurations remove unused $ imports and beforeTest hooks that installed Playwright Chromium dependencies. The Rspack configuration now installs only Playwright WebKit and documents that Chromium is provided by GitHub’s Chrome environment.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/remove-rstest-playwright-setup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5ebedc4d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/rspack/rstest.ts
beforeTest: async () => {
await $`pnpm exec playwright install chromium webkit --with-deps`;
// Browser e2e still covers WebKit; Chromium uses GitHub's Chrome.
await $`pnpm exec playwright install webkit`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep Chromium installation for non-GitHub runs

When this suite is run locally via pnpm test --stack rspack rstest, GITHUB_ACTIONS is absent, so Rstest does not select the GitHub runner's system Chrome; this hook now downloads only WebKit even though the e2e suite still covers Chromium, leaving Playwright without a Chromium executable on a clean checkout. Preserve the Chromium install outside GitHub Actions (and likewise in the other changed Rstest suites) while skipping it only when the system Chrome channel is actually selected.

AGENTS.md reference: AGENTS.md:L7-L9

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant