chore(ci): remove redundant Rstest Playwright setup - #81
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe test configurations remove unused ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5ebedc4d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| beforeTest: async () => { | ||
| await $`pnpm exec playwright install chromium webkit --with-deps`; | ||
| // Browser e2e still covers WebKit; Chromium uses GitHub's Chrome. | ||
| await $`pnpm exec playwright install webkit`; |
There was a problem hiding this comment.
Keep Chromium installation for non-GitHub runs
When this suite is run locally via pnpm test --stack rspack rstest, GITHUB_ACTIONS is absent, so Rstest does not select the GitHub runner's system Chrome; this hook now downloads only WebKit even though the e2e suite still covers Chromium, leaving Playwright without a Chromium executable on a clean checkout. Preserve the Chromium install outside GitHub Actions (and likewise in the other changed Rstest suites) while skipping it only when the system Chrome channel is actually selected.
AGENTS.md reference: AGENTS.md:L7-L9
Useful? React with 👍 / 👎.
Important
The
--with-depsexperiment failed after this PR was merged.rspack (rstest)showed thatubuntu-latestlacks required WebKit libraries. Follow-up #82 restores--with-deps.Summary
Why
Rstest selects the system Chrome channel in CI, and rstack-examples does the same after rstackjs/rstack-examples#486. This follows the cleanup in web-infra-dev/rslib#1531.
Rspack's Rstest suite still explicitly covers WebKit, so that browser must continue to be installed.
--with-depsCI experimentThis PR intentionally removed
--with-deps. The long-runningrspack (rstest)job reachedbrowser-mode/webkit.test.tsafter merge, then failed becauseubuntu-latestwas missinglibgtk-4.so.1,libgraphene-1.0.so.0,libevent-2.1.so.7, Opus, and several GStreamer libraries.The result proves WebKit still requires
--with-deps; #82 restores it without reverting the safe Chromium cleanup.Validation
pnpm lintgit diff --checkrsbuild (rstest),rslib (rstest), andrstest (examples)passed without installing ChromiumGITHUB_ACTIONS=true, including all three browser-mode examples