fix(ci): restore WebKit system dependencies - #82
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe WebKit Playwright test setup now runs the installation command with ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
--with-depswhen installing WebKit for the Rspack/Rstest suite.The Chromium cleanup from #81 remains unchanged: CI browser tests continue to use the GitHub runner's Chrome channel, while only WebKit and its required Linux libraries are installed explicitly.
Root cause
#81 was merged before its long-running
rspack (rstest)job completed. That job later reachedbrowser-mode/webkit.test.tsand failed becauseubuntu-latestwas missing WebKit libraries including:libgtk-4.so.1libgraphene-1.0.so.0libevent-2.1.so.7Failure: https://github.com/rstackjs/rstack-ecosystem-ci/actions/runs/30607433958/job/91085611278
Validation
pnpm lintgit diff --checkrsbuild (rstest),rslib (rstest), andrstest (examples)jobs passed without Chromium installationrspack (rstest)run with--with-depspassed: https://github.com/rstackjs/rstack-ecosystem-ci/actions/runs/30600454434/job/91064469839