Skip to content

fix(ci): restore WebKit system dependencies - #82

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/restore-rstest-webkit-deps
Aug 1, 2026
Merged

fix(ci): restore WebKit system dependencies#82
chenjiahan merged 1 commit into
mainfrom
chenjiahan/restore-rstest-webkit-deps

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

Restore --with-deps when installing WebKit for the Rspack/Rstest suite.

The Chromium cleanup from #81 remains unchanged: CI browser tests continue to use the GitHub runner's Chrome channel, while only WebKit and its required Linux libraries are installed explicitly.

Root cause

#81 was merged before its long-running rspack (rstest) job completed. That job later reached browser-mode/webkit.test.ts and failed because ubuntu-latest was missing WebKit libraries including:

  • libgtk-4.so.1
  • libgraphene-1.0.so.0
  • libevent-2.1.so.7
  • Opus and several GStreamer libraries

Failure: https://github.com/rstackjs/rstack-ecosystem-ci/actions/runs/30607433958/job/91085611278

Validation

@chenjiahan
chenjiahan marked this pull request as ready for review August 1, 2026 00:53
@chenjiahan
chenjiahan merged commit 5c82b5e into main Aug 1, 2026
34 of 35 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/restore-rstest-webkit-deps branch August 1, 2026 00:53
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f2c53a77-9296-4a6e-bef3-ab6151b80fe7

📥 Commits

Reviewing files that changed from the base of the PR and between 84c8b2b and e31869a.

📒 Files selected for processing (1)
  • tests/rspack/rstest.ts

📝 Walkthrough

Walkthrough

The WebKit Playwright test setup now runs the installation command with --with-deps. This replaces the browser-only installation command.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/restore-rstest-webkit-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant