Skip to content

chore(ci): use preinstalled Chrome for browser tests - #486

Merged
chenjiahan merged 3 commits into
mainfrom
chenjiahan/chore-ci-system-chrome
Jul 31, 2026
Merged

chore(ci): use preinstalled Chrome for browser tests#486
chenjiahan merged 3 commits into
mainfrom
chenjiahan/chore-ci-system-chrome

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

CI currently downloads Playwright's Chromium even though the hosted runner already provides Chrome.

This PR configures all Rstest browser examples to launch the preinstalled Chrome when GITHUB_ACTIONS is set and removes the redundant Playwright browser installation step. Local development continues to use Playwright's default Chromium.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The CI workflow no longer installs Playwright Chromium. Browser test configurations select the runner’s existing Chrome channel when CI is set. Outside CI, the configurations leave browser provider options undefined.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main CI change: browser tests use the preinstalled Chrome browser.
Description check ✅ Passed The description accurately explains the CI configuration changes and the preserved local development behavior.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/chore-ci-system-chrome

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d3e0fd5c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rstest/browser-locator/rstest.config.ts Outdated
@chenjiahan
chenjiahan merged commit cb1ae3e into main Jul 31, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/chore-ci-system-chrome branch July 31, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant