add c_variadic_experimental_arch feature#155974
Open
folkertdev wants to merge 1 commit intorust-lang:mainfrom
Open
add c_variadic_experimental_arch feature#155974folkertdev wants to merge 1 commit intorust-lang:mainfrom
c_variadic_experimental_arch feature#155974folkertdev wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
c-variadic-experimental-arch
branch
2 times, most recently
from
531be28 to
c5b7925
Compare
Member
|
This looks reasonable to me, based on the discussions in the lang meeting. We can always un-gate any of these targets in the future, when a maintainer of the target takes a close look and makes sure the tests pass. I think it might be useful to point people to an invocation of r=me with such a comment added next to the match arm for the unstable targets. (Not next to the match arm for RISC-V ILP32E, that one is unstable for a different reason.) @bors delegate+ |
Contributor
|
✌️ @folkertdev, you can now approve this pull request! If @joshtriplett told you to " |
folkertdev
force-pushed
the
c-variadic-experimental-arch
branch
from
c5b7925 to
41796ec
Compare
This was referenced Apr 29, 2026
Contributor
Author
|
r? joshtriplett |
Collaborator
|
|
Collaborator
|
These commits modify compiler targets. |
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors r=joshtriplett |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 30, 2026
…-arch, r=joshtriplett add `c_variadic_experimental_arch` feature tracking issue: rust-lang#155973 Based on https://hackmd.io/pIbUgMQuQcGaibJcinOcEw#Stabilize-c-variadic-function-definitions-rust155697, we'll gate niche targets where we don't control the implementation of `va_arg`, the ABI is unclear, or in general where we're not confident stabilizing the implementation.
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 30, 2026
Rollup of 6 pull requests Successful merges: - #155853 (Use `_mcount` as the mcount symbol name on RISC-V Linux GNU targets) - #155939 (Add feature gate for view_types experiment) - #155974 (add `c_variadic_experimental_arch` feature) - #155523 (Reorganize `tests/ui/issues/` - 02) - #155980 (Move `feature*` methods from `parse` mod to `errors` mod.) - #155987 (Make lifting infallible) Failed merges: - #155237 (Disentangle AST crates and error crates)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 30, 2026
…-arch, r=joshtriplett add `c_variadic_experimental_arch` feature tracking issue: rust-lang#155973 Based on https://hackmd.io/pIbUgMQuQcGaibJcinOcEw#Stabilize-c-variadic-function-definitions-rust155697, we'll gate niche targets where we don't control the implementation of `va_arg`, the ABI is unclear, or in general where we're not confident stabilizing the implementation.
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 30, 2026
…uwer Rollup of 13 pull requests Successful merges: - #155249 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup) - #155853 (Use `_mcount` as the mcount symbol name on RISC-V Linux GNU targets) - #155919 (simplify `ast_fragments!`) - #155939 (Add feature gate for view_types experiment) - #155974 (add `c_variadic_experimental_arch` feature) - #155991 (Catch unwinds from the global ctxt callback to complete queries profiling data in more cases) - #156003 (Pass Session to optimize_and_codegen_fat_lto) - #153566 (Add suggestion for E0401 on inner const items) - #154610 (Suggest public re-exports when a private module makes an import path inaccessible) - #155523 (Reorganize `tests/ui/issues/` - 02) - #155980 (Move `feature*` methods from `parse` mod to `errors` mod.) - #155987 (Make lifting infallible) - #155988 (tests/run-make/print-cfg: add Android target_env case)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #155973
Based on https://hackmd.io/pIbUgMQuQcGaibJcinOcEw#Stabilize-c-variadic-function-definitions-rust155697, we'll gate niche targets where we don't control the implementation of
va_arg, the ABI is unclear, or in general where we're not confident stabilizing the implementation.