[6.x] Add padding around 2FA QR code for dark mode scanning#14460
Merged
jasonvarga merged 4 commits into6.xfrom Apr 8, 2026
Merged
[6.x] Add padding around 2FA QR code for dark mode scanning#14460jasonvarga merged 4 commits into6.xfrom
jasonvarga merged 4 commits into6.xfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
Added a border because the added padding in light mode made the edges of the qr misaligned. Rounded corners to match the inputs. |
Restore the default 4-module margin in RendererStyle instead of overriding it to 0, giving the QR code a spec-compliant quiet zone for reliable scanning in dark mode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
Turns out the p-2 was probably not enough of a quiet zone. We were removing the margin in PHP. I've changed it to use the default, which I would assume is plenty. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the 2FA setup QR code was difficult to scan on Android devices when using dark mode.
This was happening because the QR code SVG had no "quiet zone" (white border) around it, making it hard for scanners to detect the code boundaries against a dark background.
This PR fixes it by adding padding to the QR code container.
Before
After
Fixes #14445