Skip to content

[6.x] Add padding around 2FA QR code for dark mode scanning #14460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 4 commits into from
Apr 8, 2026
+2 −2
Merged

[6.x] Add padding around 2FA QR code for dark mode scanning #14460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0864bea
add a little around the 2fa qr code
duncanmcclean Apr 8, 2026
0dd6c0f
Add border and rounded corners to 2FA QR code container
jasonvarga Apr 8, 2026
1383224
Use proper QR code quiet zone margin instead of CSS padding
jasonvarga Apr 8, 2026
71fac30
Use named arguments for RendererStyle constructor
jasonvarga Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/js/components/two-factor/Setup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ watch(setupModalOpen, (open) => {
<ui-description class="mb-6">{{ __('statamic::messages.two_factor_setup_instructions') }}</ui-description>

<div class="flex space-x-6">
<div class="bg-white" v-html="qrCode"></div>
<div class="shrink-0 rounded-md border border-gray-200 dark:border-none overflow-hidden" v-html="qrCode"></div>
<div class="space-y-6 w-full">
<ui-field :label="__('Setup Key')">
<ui-input copyable readonly :model-value="secretKey" />
Expand Down
2 changes: 1 addition & 1 deletion src/Auth/User.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ public function twoFactorQrCodeSvg(): string
{
$svg = (new Writer(
new ImageRenderer(
new RendererStyle(192, 0, null, null, Fill::uniformColor(new Rgb(255, 255, 255), new Rgb(45, 55, 72))),
new RendererStyle(size: 192, fill: Fill::uniformColor(new Rgb(255, 255, 255), new Rgb(45, 55, 72))),
new SvgImageBackEnd
)
))->writeString($this->twoFactorQrCodeUrl());
Expand Down
Loading