fix(web): avoid session misclicks during live reordering - #1099
Open
NPUlrk wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the original implementation. I have prepared a refreshed PR based on the current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Active sessions can reorder whenever SSE updates change
updatedAt. The long-press hook previously invokedonClickfrom each row'smouseuphandler without verifying that the press began on that same row.If a row moved between mouse down and mouse up, the row newly positioned under the stationary pointer handled
mouseupand navigated to the wrong session.Testing
bun typecheckbun run testAI disclosure
This change was developed with assistance from OpenAI Codex. The reported behavior was reproduced with a regression test, and the resulting diff was reviewed and validated with the repository's full typecheck and test suites.