fix(web): avoid session misclicks during live reordering - #1656
Open
techotaku39 wants to merge 1 commit into
Open
fix(web): avoid session misclicks during live reordering#1656techotaku39 wants to merge 1 commit into
techotaku39 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Findings
- None.
Summary
Review mode: initial
No reportable issues found in the added or modified lines. Residual risk: the live-reorder regression is covered with synthetic DOM events, so browser-specific native click targeting remains dependent on the reported manual Edge PWA validation.
Testing
- Not run (automation). GitHub checks at review time: integration pass; test pending. Suggested follow-up coverage: a Playwright case that performs a real pointer press, reorders the keyed rows, and releases over the replacement row.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
When the session list reorders while the pointer is held, releasing over a different session row can cause that row to be selected. This is reproducible in the Edge-installed Hapi PWA by holding on one session and releasing over another session row.
This PR is a refreshed, rebased continuation of #1099, originally authored by NPUlrk. It is based on the current
mainbranch and retains the touch ghost-click protection from #1185.Summary
mouseup.Validation
Passed:
bun typecheckpwsh -NoProfile -File .\\scripts\\Invoke-HapiTaskPlaywright.ps1 -Name investigate-edge-pwa-longpress-session-switch -Suite Root -TestArgs 'terminal-wrap-fidelity.spec.ts'— 2 passed..\\node_modules\\.bin\\vitest.exe run src/hooks/useLongPress.test.tsx src/components/SessionList.directory-action.test.tsx— 50 passedbun run build— passedbun run test:shared— 294 passedThe repository-wide suites were also run on Windows. They are not fully green because of unrelated platform-sensitive failures outside the changed files:
bun run teststops during CLI tests at 2 unrelated Windows permission/path failures.bun run test:web— 266 files passed; 3 fixture files failed (76 tests) because of LF/CRLF canonical serialization.bun run test:hub— 1,199 passed, 3 skipped, and 6 unrelated Windows/path/config failures.bun run test:relay— 79 passed and 1 unrelatedrelay/package.jsonpath failure.Related Issues
Refs #1099AI Disclosure
OpenAI Codex (GPT-5.6) assisted with repository investigation, rebasing, implementation, test execution, and PR drafting. The changes and validation were reviewed against the source code and test results.