ci: keep binary size report in job summary for fork PRs - #2448
Open
fengmk2 wants to merge 2 commits into
Open
Conversation
Fork pull_request runs get a read-only token, so the whole workflow was gated to same-repo PRs and fork PRs got no size report at all. Drop the fork gate from the inputs job so fork PRs run the native input compare and the base/head builds. The comment job now always writes the size table to the job summary and returns before the comment API calls when the PR head is a fork. Cleanup stays same-repo only because deleting a comment needs a write token.
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.67 MiB | 10.67 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.62 MiB | 4.62 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | Binary | 32.02 MiB | 32.02 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.61 MiB | 12.61 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 7.98 MiB | 7.98 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 4.03 MiB | 4.03 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | Binary | 39.68 MiB | 39.68 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.92 MiB | 16.92 MiB | 0 B (0.00%) |
vp (Windows x64) |
Binary | 8.55 MiB | 8.55 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.73 MiB | 3.73 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | Binary | 26.89 MiB | 26.89 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.68 MiB | 10.68 MiB | 0 B (0.00%) |
| Trampoline (Windows x64) | Binary | 205.00 KiB | 205.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 99.00 KiB | 99.00 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.47 MiB | 4.47 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.09 MiB | 2.09 MiB | 0 B (0.00%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork
pull_requestruns get a read-only token, sovp-binary-size.ymlgated every job to same-repo PRs. Fork PRs that change native inputs (for example #2346, which touches Cargo.lock and many crates) got no size report at all.Changes:
inputsjob, so fork PRs run the native input compare and the base/head builds when inputs changed.commentjob run for fork PRs. It always writes the size table to the job summary, and returns before the comment API calls when the PR head is a fork.cleanupjob same-repo only, because comment deletion needs a write token.Same-repo PRs keep the current behavior, summary plus sticky comment. Fork PRs get the report in the run's job summary.
The build jobs receive no secrets, checkout uses
persist-credentials: false, and the Rust cache save is disabled, so the untrusted fork code runs with the same exposure as the regular CI jobs that already run for fork PRs.