Skip to content

ci: keep binary size report in job summary for fork PRs #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 3 commits into from
Aug 16, 2026
+8 −2
Merged

ci: keep binary size report in job summary for fork PRs #2448

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65d0ebd
ci: keep binary size report in job summary for fork PRs
fengmk2 Aug 14, 2026
f591429
Merge branch 'main' into ci/binary-size-fork-summary
fengmk2 Aug 14, 2026
a577726
Merge branch 'main' into ci/binary-size-fork-summary
fengmk2 Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/vp-binary-size.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ defaults:
jobs:
inputs:
name: Detect native input changes
if: github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down Expand Up @@ -237,8 +236,9 @@ jobs:
comment:
name: Report binary size
needs: build
if: github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
# Fork runs get a read-only token regardless of this block; the script
# then keeps the report in the job summary and skips the PR comment.
permissions:
contents: read
issues: write
Expand All @@ -256,6 +256,7 @@ jobs:
env:
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
SIZE_DIR: ${{ runner.temp }}/native-size
SAME_REPO: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
with:
script: |
const fs = require('node:fs');
Expand Down Expand Up @@ -368,6 +369,11 @@ jobs:

await core.summary.addRaw(body.replace(marker, '')).write();

if (process.env.SAME_REPO !== 'true') {
core.info('Fork PR: the report stays in the job summary above.');
return;
}

const comments = await github.paginate(github.rest.issues.listComments, {
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down
Loading