Skip to content

fix(vercel): clone webpack#84

Merged
ovflowd merged 2 commits intomainfrom
vercel/clone-webpack
Apr 22, 2026
Merged

fix(vercel): clone webpack#84
ovflowd merged 2 commits intomainfrom
vercel/clone-webpack

Conversation

@avivkeller
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 22, 2026 13:20
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 22, 2026

Deployment failed with the following error:

The `vercel.json` schema validation failed with the following message: should NOT have additional property `buildCommand:`

Learn More: https://vercel.com/docs/concepts/projects/project-configuration

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 22, 2026

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: webpack-doc-kit.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@ovflowd ovflowd merged commit 5059773 into main Apr 22, 2026
3 of 4 checks passed
@ovflowd ovflowd deleted the vercel/clone-webpack branch April 22, 2026 13:22
@avivkeller avivkeller changed the title feat(vercel): clone webpack fix(vercel): clone webpack Apr 22, 2026
@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 22, 2026

Fast-tracking as a hot-fix.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a custom Vercel build step intended to run the repo’s webpack-cloning step before producing the static site output (out/) for deployment.

Changes:

  • Update vercel.json to configure a custom build command that runs clone-webpack and then build.
  • Minor JSON formatting change (adds a trailing comma after trailingSlash).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread vercel.json
"cleanUrls": true,
"trailingSlash": false
"trailingSlash": false,
"buildCommand": "node --run clone-webpack && node --run build"
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub Pages deploy workflow creates the out/ directory before running the doc-kit generation (mkdir out && npm run build-html). The new Vercel build command doesn’t do this; if doc-kit expects the output directory to exist, the Vercel build may fail. Consider adding mkdir -p out (or moving this into the build/build-html script) so all build paths behave consistently.

Suggested change
"buildCommand": "node --run clone-webpack && node --run build"
"buildCommand": "mkdir -p out && node --run clone-webpack && node --run build"

Copilot uses AI. Check for mistakes.
Comment thread vercel.json
"cleanUrls": true,
"trailingSlash": false
"trailingSlash": false,
"buildCommand": "node --run clone-webpack && node --run build"
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property name is "buildCommand:" (with a trailing colon), which won’t be recognized by Vercel’s config schema (expects buildCommand). As a result the custom build command will be ignored. Rename the key to buildCommand, and consider using the repo’s existing npm scripts (npm run clone-webpack && npm run build) instead of node --run ... to match CI and avoid relying on Node’s experimental --run support on Vercel.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants