Skip to content

fix(vercel): clone webpack #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 2 commits into from
Apr 22, 2026
Merged

fix(vercel): clone webpack #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45c9bb5
feat(vercel): clone webpack
avivkeller Apr 22, 2026
650034c
Update vercel.json
avivkeller Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vercel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"$schema": "https://openapi.vercel.sh/vercel.json",
"outputDirectory": "out",
"cleanUrls": true,
"trailingSlash": false
"trailingSlash": false,
"buildCommand": "node --run clone-webpack && node --run build"
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub Pages deploy workflow creates the out/ directory before running the doc-kit generation (mkdir out && npm run build-html). The new Vercel build command doesn’t do this; if doc-kit expects the output directory to exist, the Vercel build may fail. Consider adding mkdir -p out (or moving this into the build/build-html script) so all build paths behave consistently.

Suggested change
"buildCommand": "node --run clone-webpack && node --run build"
"buildCommand": "mkdir -p out && node --run clone-webpack && node --run build"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property name is "buildCommand:" (with a trailing colon), which won’t be recognized by Vercel’s config schema (expects buildCommand). As a result the custom build command will be ignored. Rename the key to buildCommand, and consider using the repo’s existing npm scripts (npm run clone-webpack && npm run build) instead of node --run ... to match CI and avoid relying on Node’s experimental --run support on Vercel.

Copilot uses AI. Check for mistakes.
}