cannon: Set warp timeout to default 30s from > 1 hour

[akshaymankar]

Reduce ping interval to 15s, this is also what most webapps use.

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

[supersven]

LGTM 👍

[marcoconti83]

The PR description says 20 seconds, but PR title and the changelog file you edited says 30.
The code says 20 :)

[marcoconti83]

In this contex, is "the client" anothe backend service, or the frontend? If the latter, we need to double check that no frontend client sets the interval to 30s+, otherwise they will keep be disconnected every 30s. I'm not saying they should do that, I'm saying it will impact them (and they should be fixed, but then should we roll this out)?

[akshaymankar]

Its the frontend. The webapp doesn't even have a way to use this feature since the browser APIs don't allow sending pings. I remember asking about this few months ago, but we can check again.

The websocket doesn't break if they try to use this feature, they will just not be able to control how often the backend sends pings.

[marcoconti83]

So it's for clients to ask the backend to send a ping (backend->client) at an interval of their chosing? I had assumed the other way around. Ok this makes more sense.

[akshaymankar]

Ahh, my wording could definitely be better here. Sorry about the confusion.

[akshaymankar]

The PR description says 20 seconds, but PR title and the changelog file you edited says 30. The code says 20 :)

Those configs are unused, initially I was going to make all this very extensible, but then I realized this is just a way for us to cause ourselves problems. So I removed it, then I forgot to delete these config options. I will create another PR to clean this up.

We're using defaultPingPongOptions from the websockets library: https://hackage.haskell.org/package/websockets-0.13.0.0/docs/Network-WebSockets-Connection-PingPong.html#v:defaultPingPongOptions

So the change log is correct. I will update the PR description to match.