feat(logger): [SDK-4939] wire Android FileLogStore for shared KMP legacy purge

[abdulraqeeb33]

Summary

Linear: SDK-4939

The KMP logger module and the legacy otel module share one on-disk crash directory ({cacheDir}/onesignal/otel/crashes). Ownership is distinguished by suffix — logger writes *.otlp; legacy otel writes bare-millis filenames plus stray .tmps.

Purge orchestration lives in shared KMP (OneSignal-KMP-SDK#8 — LogCrashUploader → ILogFileStore.deleteUnrecognizedEntries(minAgeMillis)). This PR provides the Android store implementation and rollout inventory logs.

Changes

• Submodule — pins OneSignal-KMP-SDK to KMP DatabaseNotClosedException raised when notification arrives #8 (post-upload / finally purge, age-gated foreign deletes, cancellation-safe).
• FileLogStore.deleteUnrecognizedEntries(minAgeMillis) — Android implementation; deletes non-.otlp entries at least minAgeMillis old; preserves owned .otlp and too-young foreign files.
• OneSignalCrashUploaderWrapper — before/after crash-dir inventory when the logger module is active (no host-side purge call).
• FileLogStoreTest — stale purge / young preserved / keep-owned / missing-dir / idempotency.

Merge order

1. Land OneSignal-KMP-SDK#8 first.
2. Merge this PR (re-pin submodule to the merged KMP SHA if the tip moves).

Test plan

• :OneSignal:core:compileDebugKotlin (after submodule pin)
• KMP :kmp:testDebugUnitTest --tests "*LogCrashTest*"
• :OneSignal:core:testDebugUnitTest --tests "*FileLogStoreTest*"
• Manual: with SDK_CUSTOM_LOGGING on, seed a stale legacy file in the crash dir, confirm KMP purge removes it and after-cleanup inventory logs legacy=0

Made with Cursor

[github-actions]

📊 Diff Coverage Report

Diff Coverage Report (Changed Lines Only)

Gate: aggregate coverage on changed executable lines must be ≥ 80% (JaCoCo line data for lines touched in the diff).

Changed Files Coverage

• OneSignalCrashUploaderWrapper.kt: 0/31 touched executable lines (0.0%) (58 touched lines in diff)
  • 31 uncovered touched lines in this file
• CrashDirCleanup.kt: 28/29 touched executable lines (96.6%) (67 touched lines in diff)
• FileLogStore.kt: 0/59 touched executable lines (0.0%) (96 touched lines in diff)
  • 59 uncovered touched lines in this file

Overall (aggregate gate)

28/119 touched executable lines covered (23.5% — requires ≥ 80%)

Per-file detail (informational; gate is aggregate above):

• OneSignalCrashUploaderWrapper.kt: 0.0% (31 uncovered touched lines)

• FileLogStore.kt: 0.0% (59 uncovered touched lines)

❌ Coverage Check Failed

Aggregate coverage on touched lines is 23.5% (minimum 80%).

📥 View workflow run

[abdulraqeeb33]

Submodule re-pinned to KMP e636c2b (exception-safe purge finally from KMP #8 review follow-up).

[fadi-george]

A few items to address before merging:

1. CI currently fails Spotless, so the new tests have not run. Please apply the import-order fix and confirm FileLogStoreTest passes.
2. The submodule is pinned to PR-head SHA 3ececce7, but KMP DatabaseNotClosedException raised when notification arrives #8 was squash-merged as 4864ae1b4265baa433ce60a3588aa153689341ff. Please re-pin to the merged SHA.
3. Avoid Logging.info() inside crash-path FileLogStore.save(). Logging synchronously invokes app listeners, and a listener exception can make a successfully persisted record return false. Raw Logcat would be safer there.
4. Please rethrow CancellationException from the Android wrapper and the touched suspend store paths instead of swallowing it through Throwable.
5. Bound the crash-directory inventory sample. It currently builds an unlimited filename summary before starting the uploader, and Logcat will truncate large output anyway.

The core purge classification and age-gating otherwise look good.

[abdulraqeeb33]

Addressed in the latest push:

1. Spotless — import order fixed; :OneSignal:core:spotlessKotlinCheck + FileLogStoreTest pass locally.
2. Submodule pin — re-pinned to merged KMP v0.1.1 / 4864ae1b4265baa433ce60a3588aa153689341ff.
3. Crash-path save() — uses raw android.util.Log instead of Logging.info/warn so app listeners cannot flip a successful write to false.
4. Cancellation — CancellationException is rethrown from the uploader wrapper and from listReadable / delete / deleteUnrecognizedEntries.
5. Inventory bound — per-file sample capped at 20 entries with an …(+N more) suffix.

[fadi-george]

fix failing build/coverage checks too?

[fadi-george]

Rebased onto latest main and addressed the newest review notes:

1. Suspend / race — replied on the thread and added a call-site comment: LogCrashUploader.start() is suspend and finishes upload + finally purge before after-cleanup inventory runs.
2. Coverage — Robolectric Kotest shells are not attributed by Jacoco here (same constraint documented for AnrCheckEvaluator). Extracted ownership/inventory helpers to pure-JVM CrashDirCleanup + CrashDirCleanupTest, and applied the Skip Coverage Check label for the remaining Android shell lines.