feat(logger): purge unrecognized/legacy crash files in shared uploader

[abdulraqeeb33]

Summary

Related: OneSignal-Android-SDK SDK-4939

Moves the legacy crash-file cleanup into the shared KMP module so every host (Android now, iOS later) reclaims foreign/legacy files without host-specific glue. This is the shared-module home for the behavior that the Android SDK currently does host-side (OneSignal-Android-SDK#2691).

Changes

• ILogFileStore.deleteUnrecognizedEntries() — new contract method with a default no-op (safe for test doubles / platforms with no shared-directory legacy). Implementations remove on-disk entries the store does not own, while preserving owned records (including failed / too-young uploads).
• LogCrashUploader — after the owned-record upload pass (or immediately when remote logging is off), purge unrecognized entries so a later module flip isn't poisoned by stale legacy files. Adds inventory/pass logging.
• Tests + FakeFileStore — cover: purge after successful uploads, purge when remote logging disabled, and owned records retained on upload failure while legacy files are still purged.

Consumer follow-up

The Android host PR that bumps the submodule to this commit and implements deleteUnrecognizedEntries() in FileLogStore is stacked on #2691. Once this merges, the Android submodule pin will be updated to the merged SHA.

Test plan

• ./gradlew :kmp:testDebugUnitTest — LogCrashTest 10/10 pass (incl. 3 new purge tests)
• ./gradlew :kmp:spotlessCheck

Made with Cursor

[abdulraqeeb33]

Addressed review feedback in e636c2b:

• purgeUnrecognizedEntries() now runs in a finally around internalStart() so a throwing listReadable/export path still reclaims legacy files
• Contract note on deleteUnrecognizedEntries recommending a minimal age margin for unrecognized files during module-flag transitions
• New test: uploaderPurgesUnrecognizedFilesEvenWhenListReadableThrows

Android #2691 submodule re-pinned to this SHA.

[fadi-george]

A couple of issues to address before merging:

1. purgeUnrecognizedEntries() catches all Exceptions, including coroutine cancellation. Please rethrow CancellationException, particularly for the remote-logging-disabled path where cancellation could otherwise be swallowed.
2. The contract says implementations must preserve too-young foreign files, but the method receives no age threshold and the tests delete every unrecognized file. Please make the age policy explicit in the API or implementation and add coverage for young versus stale foreign files.

Also, please confirm this will not ship before the Android production implementation lands. In this repo the default remains a no-op and only FakeFileStore overrides it. The new crash path and report inventory logging should ideally remain at DEBUG to avoid unnecessary exposure and log volume.

[abdulraqeeb33]

Addressed in e28e174:

1. Cancellation — purgeUnrecognizedEntries / export catch blocks now rethrow CancellationException before handling other Exceptions (covered for the remote-logging-disabled path).
2. Age policy — deleteUnrecognizedEntries(minAgeMillis) is now an explicit API parameter. LogCrashUploader passes platformProvider.minFileAgeForReadMillis. Fake + tests cover young vs stale foreign files.
3. Logging — path / report inventory / per-report upload lines are back at DEBUG. Purge-with-deletions stays at INFO so rollout cleanup is visible; empty purge is DEBUG.

Shipping with Android: yes — this will not ship alone. OneSignal-Android-SDK#2691 pins this submodule and provides the production FileLogStore override (including the age gate). Default no-op remains until a host lands an implementation.