Fix security: credential permissions, CAS validation, token redaction#1028
Merged
Conversation
Contributor
Author
This was referenced Apr 9, 2026
jwiegley
force-pushed
the
johnw/review-security-fixes
branch
from
bbff7f0 to
eb75b9b
Compare
jwiegley
force-pushed
the
johnw/review-vscode-extension
branch
from
29765bf to
aefe992
Compare
jwiegley
force-pushed
the
johnw/review-security-fixes
branch
from
eb75b9b to
897edee
Compare
jwiegley
force-pushed
the
johnw/review-vscode-extension
branch
from
aefe992 to
5780c9a
Compare
svarlamov
force-pushed
the
johnw/review-vscode-extension
branch
2 times, most recently
from
cfb5bd0 to
e78647c
Compare
svarlamov
force-pushed
the
johnw/review-security-fixes
branch
from
897edee to
b43e12d
Compare
jwiegley
changed the base branch from
johnw/review-vscode-extension
to
graphite-base/1028
jwiegley
force-pushed
the
graphite-base/1028
branch
from
e78647c to
b050b15
Compare
jwiegley
force-pushed
the
johnw/review-security-fixes
branch
from
b43e12d to
86f70d0
Compare
- Create credential files atomically with mode 0600 on Unix to prevent a window where they exist with default permissions - Validate CAS hashes are hex-only before building query URLs - Implement custom Debug for ApiContext to redact auth_token and api_key - Replace RefCell with Mutex in MockBackend to derive Send+Sync safely instead of using unsafe impl Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
johnw/review-security-fixes
branch
from
86f70d0 to
7eaef28
Compare
Contributor
Qodana for JVMAnalyzed project: 2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a window where they exist with default permissions
instead of using unsafe impl
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com