Add integration tests for Graphite operations and missing attribution

[jwiegley]

New test suites covering two important scenarios: simulating Graphite
CLI git operations (stack creation, rebase, amend workflows) and
reproducing the intermittent bug where attribution incorrectly reports
100% human authorship. Adds allow_daemon_errors flag to test harness
for controlled daemon failure testing.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

[jwiegley]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Add wall-clock timeout and SSH hardening to authorship note fetch #1184
• Add attribution test writing guidelines to AGENTS.md #1033
• Add integration tests for Graphite operations and missing attribution #1032 👈 (View in Graphite)
• Replace silent error swallowing with debug logging #1031
• Refactor CheckpointKind API and improve attribution/storage performance #1030
• Harden daemon: socket permissions, env safety, telemetry, rewrite locking #1029
• Fix security: credential permissions, CAS validation, token redaction #1028
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

[devin-ai-integration]

Devin Review found 1 new potential issue.

View 14 additional findings in Devin Review.

[devin-ai-integration]

🟡 Indentation regression in new_worktree() and new_with_remote() violates AGENTS.md formatting rule

The PR introduces incorrect indentation for new_worktree() at tests/integration/repos/test_repo.rs:1110-1112 and new_with_remote() with its doc comment at tests/integration/repos/test_repo.rs:1237-1254. Both methods are inside an impl TestRepo block but their bodies and closing braces are de-indented to module level. This violates the AGENTS.md rule: "Before opening a PR, make sure to run task lint and task fmt and resolve any formatting/lint issues as they will fail in CI." The code compiles correctly since Rust doesn't rely on indentation, but it will fail CI formatting checks.

Suggested change

	pub fn new_worktree() -> Self {
	Self::new_worktree_with_mode(GitTestMode::from_env())
	}
	Self::new_worktree_with_mode(GitTestMode::from_env())
	}
	pub fn new_worktree() -> Self {
	Self::new_worktree_with_mode(GitTestMode::from_env())
	}

---

Was this helpful? React with 👍 or 👎 to provide feedback.

[devin-ai-integration]

Devin Review found 1 new potential issue.

View 15 additional findings in Devin Review.

[devin-ai-integration]

🟡 Formatting regression: new_with_remote() and its doc comments lost impl-block indentation

The new_with_remote() method, its doc comments (lines 1238-1251), function signature (line 1252), body (line 1253), and closing brace (line 1254) all lost their 4-space impl-block indentation. The old code had proper /// and pub fn indentation. AGENTS.md explicitly requires: "Before opening a PR, make sure to run task lint and task fmt and resolve any formatting/lint issues as they will fail in CI." This would fail rustfmt.

Suggested change

	/// The mirror is cloned from the upstream, so "origin" is automatically configured.
	/// Returns (mirror, upstream) tuple.
	///
	/// # Example
	/// ```ignore
	/// let (mirror, upstream) = TestRepo::new_with_remote();
	///
	/// // Make changes in mirror
	/// mirror.filename("test.txt").write("hello").stage();
	/// mirror.commit("initial commit");
	///
	/// // Push to upstream
	/// mirror.git(&["push", "origin", "main"]);
	/// ```
	pub fn new_with_remote() -> (Self, Self) {
	Self::new_with_remote_with_mode(GitTestMode::from_env())
	}
	/// The mirror is cloned from the upstream, so "origin" is automatically configured.
	/// Returns (mirror, upstream) tuple.
	///
	/// # Example
	/// ```ignore
	/// let (mirror, upstream) = TestRepo::new_with_remote();
	///
	/// // Make changes in mirror
	/// mirror.filename("test.txt").write("hello").stage();
	/// mirror.commit("initial commit");
	///
	/// // Push to upstream
	/// mirror.git(&["push", "origin", "main"]);
	/// ```
	pub fn new_with_remote() -> (Self, Self) {
	Self::new_with_remote_with_mode(GitTestMode::from_env())
	}

---

Was this helpful? React with 👍 or 👎 to provide feedback.