Replace silent error swallowing with debug logging#1031
Closed
jwiegley wants to merge 1 commit into
Closed
Conversation
This was referenced Apr 9, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 9, 2026
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
from
de93054 to
2c481e0
Compare
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
2 times, most recently
from
93b3136 to
a4a730d
Compare
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
2 times, most recently
from
461e97a to
ea06f26
Compare
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
2 times, most recently
from
1338d42 to
a09eb0b
Compare
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
from
ea06f26 to
22ea859
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
from
22ea859 to
3ba0e3d
Compare
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
from
a09eb0b to
90c6d77
Compare
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
from
3ba0e3d to
ade6c88
Compare
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
from
90c6d77 to
7c12fb9
Compare
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
from
e6fc162 to
e70d3b2
Compare
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
2 times, most recently
from
b3492b6 to
1d44bd3
Compare
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
from
e70d3b2 to
0d06c80
Compare
jwiegley
changed the base branch from
johnw/review-refactor-api
to
graphite-base/1031
jwiegley
force-pushed
the
graphite-base/1031
branch
from
0d06c80 to
78fe96c
Compare
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
from
1d44bd3 to
4e85bd0
Compare
jwiegley
changed the base branch from
graphite-base/1031
to
johnw/review-refactor-api
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
from
78fe96c to
aac086e
Compare
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
from
4e85bd0 to
faff2e0
Compare
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
from
faff2e0 to
77355a3
Compare
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
2 times, most recently
from
16b9ae1 to
9cb2f68
Compare
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
2 times, most recently
from
81a24be to
5f259b5
Compare
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
from
9cb2f68 to
0d6bcf0
Compare
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
from
5f259b5 to
768ad5a
Compare
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
from
0d6bcf0 to
8a15685
Compare
Convert `let _ =` patterns to `if let Err(e)` with debug_log throughout hook handlers, preventing silent failures that made production issues difficult to diagnose. Also hardens error handling in virtual attribution (unwrap_or_default -> match with continue), repository rewrite log reads, and metrics timestamp conversion. Adds is_dummy guard to internal_db to warn when the dummy database is used in non-test contexts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
johnw/review-silent-errors
branch
from
768ad5a to
2e651dd
Compare
jwiegley
force-pushed
the
johnw/review-refactor-api
branch
from
8a15685 to
2818389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
let _ =patterns toif let Err(e)with debug_logthroughout hook handlers, preventing silent failures that made
production issues difficult to diagnose. Also hardens error
handling in virtual attribution (unwrap_or_default -> match with
continue), repository rewrite log reads, and metrics timestamp
conversion. Adds is_dummy guard to internal_db to warn when the
dummy database is used in non-test contexts.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com