fix: update cache key generation for secondary caches

[wschurman]

Why

Similar to #601, it was possible for a misconfigured application to have collisions in cache keys for secondary caches. Because they likely share the same redis instance at the application level, these keys need similar treatment for separating them logically from normal loader keys plus consistent delimiter escaping.

How

Hoist final key creation from application level to library level and apply consistent delimiter escaping and namespacing.

Test Plan

Run new test.

[wschurman]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix: correctness of TSMockitoExtensions isEqualWithEntityAware for SerializableKeyMaps of different length #614
• fix: fix possible composite key collision in StubDatabaseAdapter test utility #613
• chore: update comment for IEntityMetricsAdapter for implementors #612
• fix: pick method crash when object has hasOwnProperty key #611
• fix: fix behavior of AuthorizationResultBasedEntityAssociationLoader when field value is empty string #610
• feat: support numeric enums in StrictEnumField #609
• feat: validate GenericRedisCacheContext #608
• fix: skip when AllowIfAllSubRulesAllowPrivacyPolicyRule is empty #607
• fix: correct cycle guard behavior for deletion #606
• fix: handle potential infinite recursion for canViewerDeleteAsync #605
• feat: clean up transactional dataloader at transaction end #604
• fix: correct negative caching behavior in GenericSecondaryEntityCache #603
• fix: update cache key generation for secondary caches #602 👈 (View in Graphite)
• fix!: replace makeKeyFn with delimiter to strengthen guarantee of proper escaping #601
• fix: prevent collision in companion when entities share same name or same table name #600
• chore: remove unnecessary ViewerScopedEntityMutatorFactory #599
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8fb1efe) to head (b8c572c).

Additional details and impacted files

@@                                                   Coverage Diff                                                    @@
##           05-14-fix_replace_makekeyfn_with_delimiter_to_strengthen_guarantee_of_proper_escaping      #602    +/-   ##
========================================================================================================================
  Coverage                                                                                 100.00%   100.00%            
========================================================================================================================
  Files                                                                                        109       109            
  Lines                                                                                      17623     17636    +13     
  Branches                                                                                    1518       913   -605     
========================================================================================================================
+ Hits                                                                                       17623     17636    +13     

Flag	Coverage Δ
integration	28.74% <87.50%> (+0.05%)	⬆️
unittest	94.49% <12.50%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.