Skip to content

chore: update comment for IEntityMetricsAdapter for implementors#612

Merged
wschurman merged 1 commit into
mainfrom
05-14-chore_update_comment_for_ientitymetricsadapter_for_implementors
May 21, 2026
Merged

chore: update comment for IEntityMetricsAdapter for implementors#612
wschurman merged 1 commit into
mainfrom
05-14-chore_update_comment_for_ientitymetricsadapter_for_implementors

Conversation

@wschurman
Copy link
Copy Markdown
Member

@wschurman wschurman commented May 14, 2026

Why

Just a comment update to make it clearer that IEntityMetricsAdapter implementations must not throw since it'll cause adverse effects for the library.

In a follow-up, it may be good to defend against this, but it's not a straightforward fix.

How

Update comment.

Test Plan

Proofread.

Copy link
Copy Markdown
Member Author

wschurman commented May 14, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0eb8989) to head (844d8ab).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #612   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines        17739     17743    +4     
  Branches      1539      1539           
=========================================
+ Hits         17739     17743    +4     
Flag Coverage Δ
integration 28.61% <0.00%> (-0.01%) ⬇️
unittest 94.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman requested review from ide and quinlanj May 14, 2026 23:21
@wschurman wschurman marked this pull request as ready for review May 14, 2026 23:21
Comment thread packages/entity/src/metrics/IEntityMetricsAdapter.ts Outdated
@wschurman wschurman force-pushed the 05-14-chore_update_comment_for_ientitymetricsadapter_for_implementors branch from 925c810 to e5683e6 Compare May 21, 2026 16:47
Copy link
Copy Markdown
Member Author

wschurman commented May 21, 2026

Merge activity

  • May 21, 4:55 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 21, 5:33 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 21, 5:34 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from 05-14-fix_pick_method_crash_when_object_has_hasownproperty_key to graphite-base/612 May 21, 2026 17:29
@wschurman wschurman changed the base branch from graphite-base/612 to main May 21, 2026 17:31
@wschurman wschurman force-pushed the 05-14-chore_update_comment_for_ientitymetricsadapter_for_implementors branch from e5683e6 to 844d8ab Compare May 21, 2026 17:32
@wschurman wschurman merged commit ecf1608 into main May 21, 2026
6 checks passed
@wschurman wschurman deleted the 05-14-chore_update_comment_for_ientitymetricsadapter_for_implementors branch May 21, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants