Skip to content

fix: fix possible composite key collision in StubDatabaseAdapter test utility#613

Open
wschurman wants to merge 1 commit into
05-14-chore_update_comment_for_ientitymetricsadapter_for_implementorsfrom
05-14-fix_fix_possible_composite_key_collision_in_stubdatabaseadapter_test_utility
Open

fix: fix possible composite key collision in StubDatabaseAdapter test utility#613
wschurman wants to merge 1 commit into
05-14-chore_update_comment_for_ientitymetricsadapter_for_implementorsfrom
05-14-fix_fix_possible_composite_key_collision_in_stubdatabaseadapter_test_utility

Conversation

@wschurman
Copy link
Copy Markdown
Member

@wschurman wschurman commented May 14, 2026

Why

The stub adapters were doing a simple : join, so it was possible for two rows to collide in the stub adapter during tests, if value has the delimiter.

How

Fix is to use JSON.stringify so that only truly same rows map to the same thing.

Test Plan

Run new tests.

Copy link
Copy Markdown
Member Author

wschurman commented May 14, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (925c810) to head (fb9f279).

Additional details and impacted files
@@                                           Coverage Diff                                           @@
##           05-14-chore_update_comment_for_ientitymetricsadapter_for_implementors      #613   +/-   ##
=======================================================================================================
  Coverage                                                                 100.00%   100.00%           
=======================================================================================================
  Files                                                                        109       109           
  Lines                                                                      17741     17741           
  Branches                                                                     917       932   +15     
=======================================================================================================
  Hits                                                                       17741     17741           
Flag Coverage Δ
integration 28.62% <0.00%> (ø)
unittest 94.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman requested review from ide and quinlanj May 14, 2026 23:21
@wschurman wschurman marked this pull request as ready for review May 14, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants